Static-check fixes from @lespea #1657, batch 3/n

pkg/bifs/arithmetic.go

@@ -834,7 +834,7 @@
 // a=F | min=a min=a
 // a=T | min=b min=b
 func min_b_bb(input1, input2 *mlrval.Mlrval) *mlrval.Mlrval {
-	if input1.AcquireBoolValue() == false {
+	if !input1.AcquireBoolValue() {
 		return input1
 	} else {
 		return input2
@@ -947,7 +947,7 @@
 	// Do the bulk arithmetic on native ints not Mlrvals, to avoid unnecessary allocation.
 	retval := lib.UTF8Strlen(mlrvals[0].OriginalString())
 	for i, _ := range mlrvals {
 		clen := lib.UTF8Strlen(mlrvals[i].OriginalString())
 		if clen < retval {
 			retval = clen
 		}
@@ -1004,7 +1004,7 @@
 // a=F | max=a max=b
 // a=T | max=a max=b
 func max_b_bb(input1, input2 *mlrval.Mlrval) *mlrval.Mlrval {
-	if input2.AcquireBoolValue() == false {
+	if !input2.AcquireBoolValue() {
 		return input1
 	} else {
 		return input2

pkg/bifs/cmp.go

@@ -246,7 +246,7 @@ func eq_b_aa(input1, input2 *mlrval.Mlrval) *mlrval.Mlrval {
 	for i := range a {
 		eq := BIF_equals(a[i], b[i])
 		lib.InternalCodingErrorIf(eq.Type() != mlrval.MT_BOOL)
-		if eq.AcquireBoolValue() == false {
+		if !eq.AcquireBoolValue() {
 			return mlrval.FALSE
 		}
 	}

pkg/bifs/types.go

@@ -37,7 +37,7 @@ func float_to_int(input1 *mlrval.Mlrval) *mlrval.Mlrval {
 }
 
 func bool_to_int(input1 *mlrval.Mlrval) *mlrval.Mlrval {
-	if input1.AcquireBoolValue() == true {
+	if input1.AcquireBoolValue() {
 		return mlrval.FromInt(1)
 	} else {
 		return mlrval.FromInt(0)
@@ -92,7 +92,7 @@ func float_to_int_with_base(input1, input2 *mlrval.Mlrval) *mlrval.Mlrval {
 }
 
 func bool_to_int_with_base(input1, input2 *mlrval.Mlrval) *mlrval.Mlrval {
-	if input1.AcquireBoolValue() == true {
+	if input1.AcquireBoolValue() {
 		return mlrval.FromInt(1)
 	} else {
 		return mlrval.FromInt(0)
@@ -146,7 +146,7 @@ func int_to_float(input1 *mlrval.Mlrval) *mlrval.Mlrval {
 }
 
 func bool_to_float(input1 *mlrval.Mlrval) *mlrval.Mlrval {
-	if input1.AcquireBoolValue() == true {
+	if input1.AcquireBoolValue() {
 		return mlrval.FromFloat(1.0)
 	} else {
 		return mlrval.FromFloat(0.0)

pkg/climain/mlrcli_parse.go

@@ -295,7 +295,7 @@ func parseCommandLinePassTwo(
 		rc := cli.FLAG_TABLE.Parse(args, argc, &argi, options)
 
 		// Should have been parsed OK in pass one.
-		lib.InternalCodingErrorIf(rc != true)
+		lib.InternalCodingErrorIf(!rc)
 		// Make sure we consumed the entire flag sequence as parsed by pass one.
 		lib.InternalCodingErrorIf(argi != argc)
 	}

pkg/dsl/cst/builtin_function_manager.go

@@ -2595,7 +2595,7 @@ func (manager *BuiltinFunctionManager) getBuiltinFunctionClasses() []string {
 	classesList := make([]string, 0)
 	for _, builtinFunctionInfo := range *manager.lookupTable {
 		class := string(builtinFunctionInfo.class)
-		if classesSeen[class] == false {
+		if !classesSeen[class] {
 			classesList = append(classesList, class)
 			classesSeen[class] = true
 		}

pkg/dsl/cst/builtin_functions.go

@@ -945,7 +945,7 @@ func (node *StandardTernaryOperatorNode) Evaluate(
 	}
 
 	// Short-circuit: defer evaluation unless needed
-	if boolValue == true {
+	if boolValue {
 		return node.b.Evaluate(state)
 	} else {
 		return node.c.Evaluate(state)

pkg/dsl/cst/cond.go

@@ -66,7 +66,7 @@ func (node *CondBlockNode) Execute(
 		)
 	}
 
-	if boolValue == true {
+	if boolValue {
 		blockExitPayload, err := node.statementBlockNode.Execute(state)
 		if err != nil {
 			return nil, err

pkg/dsl/cst/for.go

@@ -902,7 +902,7 @@ func (node *TripleForLoopNode) Execute(state *runtime.State) (*BlockExitPayload,
 					dsl.TokenToLocationInfo(node.continuationExpressionToken),
 				)
 			}
-			if boolValue == false {
+			if !boolValue {
 				break
 			}
 		}

pkg/dsl/cst/if.go

@@ -134,7 +134,7 @@ func (node *IfChainNode) Execute(state *runtime.State) (*BlockExitPayload, error
 				dsl.TokenToLocationInfo(ifItem.conditionToken),
 			)
 		}
-		if boolValue == true {
+		if boolValue {
 			blockExitPayload, err := ifItem.statementBlockNode.Execute(state)
 			if err != nil {
 				return nil, err

pkg/dsl/cst/while.go

@@ -64,7 +64,7 @@ func (node *WhileLoopNode) Execute(state *runtime.State) (*BlockExitPayload, err
 				dsl.TokenToLocationInfo(node.conditionToken),
 			)
 		}
-		if boolValue != true {
+		if !boolValue {
 			break
 		}
 		blockExitPayload, err := node.statementBlockNode.Execute(state)
@@ -161,7 +161,7 @@ func (node *DoWhileLoopNode) Execute(state *runtime.State) (*BlockExitPayload, e
 				dsl.TokenToLocationInfo(node.conditionToken),
 			)
 		}
-		if boolValue == false {
+		if !boolValue {
 			break
 		}
 	}

pkg/lib/util.go

@@ -14,7 +14,7 @@ func BooleanXOR(a, b bool) bool {
 }
 
 func BoolToInt(b bool) int64 {
-	if b == false {
+	if !b {
 		return 0
 	} else {
 		return 1

pkg/mlrval/mlrval_is.go

@@ -112,10 +112,10 @@ func (mv *Mlrval) IsBool() bool {
 }
 
 func (mv *Mlrval) IsTrue() bool {
-	return mv.Type() == MT_BOOL && mv.intf.(bool) == true
+	return mv.Type() == MT_BOOL && mv.intf.(bool)
 }
 func (mv *Mlrval) IsFalse() bool {
-	return mv.Type() == MT_BOOL && mv.intf.(bool) == false
+	return mv.Type() == MT_BOOL && !mv.intf.(bool)
 }
 
 func (mv *Mlrval) IsArray() bool {

pkg/mlrval/mlrval_new.go

@@ -289,7 +289,7 @@ func FromPrevalidatedFloatString(input string, floatval float64) *Mlrval {
 }
 
 func FromBool(input bool) *Mlrval {
-	if input == true {
+	if input {
 		return TRUE
 	} else {
 		return FALSE

pkg/mlrval/mlrval_output.go

@@ -87,7 +87,7 @@ func (mv *Mlrval) setPrintRep() {
 			mv.printrep = strconv.FormatFloat(mv.intf.(float64), 'f', -1, 64)
 
 		case MT_BOOL:
-			if mv.intf.(bool) == true {
+			if mv.intf.(bool) {
 				mv.printrep = "true"
 			} else {
 				mv.printrep = "false"

pkg/output/file_output_handlers.go

@@ -399,13 +399,11 @@ func (handler *FileOutputHandler) Close() (retval error) {
 		done := false
 		for !done {
 			select {
-			case _ = <-handler.recordErroredChannel:
+			case <-handler.recordErroredChannel:
 				done = true
 				retval = errors.New("exiting due to data error") // details already printed
-				break
-			case _ = <-handler.recordDoneChannel:
+			case <-handler.recordDoneChannel:
 				done = true
-				break
 			}
 		}
 	}

pkg/stream/stream.go

@@ -95,13 +95,10 @@ func Stream(
 		select {
 		case ierr := <-inputErrorChannel:
 			retval = ierr
-			break
-		case _ = <-dataProcessingErrorChannel:
+		case <-dataProcessingErrorChannel:
 			retval = errors.New("exiting due to data error") // details already printed
-			break
-		case _ = <-doneWritingChannel:
+		case <-doneWritingChannel:
 			done = true
-			break
 		}
 	}
 

pkg/terminals/repl/verbs.go

@@ -442,11 +442,8 @@ func handleSkipOrProcessN(repl *Repl, n int64, processingNotSkipping bool) {
 	for i := int64(1); i <= n; i++ {
 		select {
 		case recordsAndContexts = <-repl.readerChannel:
-			break
 		case err = <-repl.errorChannel:
-			break
-		case _ = <-repl.appSignalNotificationChannel: // user typed control-C
-			break
+		case <-repl.appSignalNotificationChannel: // user typed control-C
 		}
 
 		if err != nil {
@@ -505,13 +502,11 @@ func handleSkipOrProcessUntil(repl *Repl, dslString string, processingNotSkippin
 		doubleBreak := false
 		select {
 		case recordsAndContexts = <-repl.readerChannel:
-			break
 		case err = <-repl.errorChannel:
-			break
-		case _ = <-repl.appSignalNotificationChannel: // user typed control-C
+		case <-repl.appSignalNotificationChannel: // user typed control-C
 			doubleBreak = true
-			break
 		}
+
 		if doubleBreak {
 			break
 		}
@@ -566,7 +561,7 @@ func skipOrProcessRecord(
 	repl.runtimeState.Update(recordAndContext.Record, &recordAndContext.Context)
 
 	// End-of-stream marker
-	if recordAndContext.EndOfStream == true {
+	if recordAndContext.EndOfStream {
 		fmt.Println("End of record stream")
 		repl.readerChannel = nil
 		repl.errorChannel = nil

pkg/transformers/aaa_chain_transformer.go

@@ -265,7 +265,7 @@ func runSingleTransformerBatch(
 		// the output channel without involving the record-transformer, since
 		// there is no record to be transformed.
 
-		if inputRecordAndContext.EndOfStream == true || inputRecordAndContext.Record != nil {
+		if inputRecordAndContext.EndOfStream || inputRecordAndContext.Record != nil {
 			recordTransformer.Transform(
 				inputRecordAndContext,
 				outputRecordsAndContexts,

pkg/transformers/put_or_filter.go

@@ -542,7 +542,7 @@ func (tr *TransformerPut) Transform(
 
 		// If there were no input records then we never executed the
 		// begin-blocks. Do so now.
-		if tr.executedBeginBlocks == false {
+		if !tr.executedBeginBlocks {
 			err := tr.cstRootNode.ExecuteBeginBlocks(tr.runtimeState)
 			if err != nil {
 				fmt.Fprintln(os.Stderr, err)

pkg/transformers/seqgen.go

@@ -192,9 +192,7 @@ func (tr *TransformerSeqgen) Transform(
 		case b := <-inputDownstreamDoneChannel:
 			outputDownstreamDoneChannel <- b
 			keepGoing = false
-			break
 		default:
-			break
 		}
 		if !keepGoing {
 			break