Static-check fixes from @lespea #1657, batch 3/n

johnkerl · Oct 27, 2024 · cb2981c · cb2981c
1 parent f04b6d7
commit cb2981c
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 19 deletions.
diff --git a/pkg/output/file_output_handlers.go b/pkg/output/file_output_handlers.go
@@ -399,13 +399,11 @@ func (handler *FileOutputHandler) Close() (retval error) {
 		done := false
 		for !done {
 			select {
-			case _ = <-handler.recordErroredChannel:
+			case <-handler.recordErroredChannel:
 				done = true
 				retval = errors.New("exiting due to data error") // details already printed
-				break
-			case _ = <-handler.recordDoneChannel:
+			case <-handler.recordDoneChannel:
 				done = true
-				break
 			}
 		}
 	}

diff --git a/pkg/stream/stream.go b/pkg/stream/stream.go
@@ -95,13 +95,10 @@ func Stream(
 		select {
 		case ierr := <-inputErrorChannel:
 			retval = ierr
-			break
-		case _ = <-dataProcessingErrorChannel:
+		case <-dataProcessingErrorChannel:
 			retval = errors.New("exiting due to data error") // details already printed
-			break
-		case _ = <-doneWritingChannel:
+		case <-doneWritingChannel:
 			done = true
-			break
 		}
 	}
 

diff --git a/pkg/terminals/repl/verbs.go b/pkg/terminals/repl/verbs.go
@@ -442,11 +442,8 @@ func handleSkipOrProcessN(repl *Repl, n int64, processingNotSkipping bool) {
 	for i := int64(1); i <= n; i++ {
 		select {
 		case recordsAndContexts = <-repl.readerChannel:
-			break
 		case err = <-repl.errorChannel:
-			break
-		case _ = <-repl.appSignalNotificationChannel: // user typed control-C
-			break
+		case <-repl.appSignalNotificationChannel: // user typed control-C
 		}
 
 		if err != nil {
@@ -505,13 +502,11 @@ func handleSkipOrProcessUntil(repl *Repl, dslString string, processingNotSkippin
 		doubleBreak := false
 		select {
 		case recordsAndContexts = <-repl.readerChannel:
-			break
 		case err = <-repl.errorChannel:
-			break
-		case _ = <-repl.appSignalNotificationChannel: // user typed control-C
+		case <-repl.appSignalNotificationChannel: // user typed control-C
 			doubleBreak = true
-			break
 		}
+
 		if doubleBreak {
 			break
 		}

diff --git a/pkg/transformers/seqgen.go b/pkg/transformers/seqgen.go
@@ -192,9 +192,7 @@ func (tr *TransformerSeqgen) Transform(
 		case b := <-inputDownstreamDoneChannel:
 			outputDownstreamDoneChannel <- b
 			keepGoing = false
-			break
 		default:
-			break
 		}
 		if !keepGoing {
 			break