Fix ignoring project vocal loudness set to 0

john-kurkowski · Sep 28, 2024 · 41cac68 · 41cac68
1 parent 1bcd135
commit 41cac68
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 50 deletions.
diff --git a/src/music/render/process.py b/src/music/render/process.py
@@ -216,7 +216,7 @@ async def process(
 
         if vocal_loudness_worth is None:
             vocal_loudness_worth = float(
-                project.metadata.get("vocal-loudness-worth") or VOCAL_LOUDNESS_WORTH
+                project.metadata.get("vocal-loudness-worth", VOCAL_LOUDNESS_WORTH)
             )
 
         results = []

diff --git a/tests/render/__snapshots__/test_render.ambr b/tests/render/__snapshots__/test_render.ambr
@@ -67,13 +67,7 @@
       'metadata.get',
       tuple(
         'vocal-loudness-worth',
-      ),
-      dict({
-      }),
-    ),
-    _Call(
-      'metadata.get().__bool__',
-      tuple(
+        2.0,
       ),
       dict({
       }),
@@ -441,13 +435,7 @@
       'metadata.get',
       tuple(
         'vocal-loudness-worth',
-      ),
-      dict({
-      }),
-    ),
-    _Call(
-      'metadata.get().__bool__',
-      tuple(
+        2.0,
       ),
       dict({
       }),
@@ -780,13 +768,7 @@
       'metadata.get',
       tuple(
         'vocal-loudness-worth',
-      ),
-      dict({
-      }),
-    ),
-    _Call(
-      'metadata.get().__bool__',
-      tuple(
+        2.0,
       ),
       dict({
       }),
@@ -1000,13 +982,7 @@
       'metadata.get',
       tuple(
         'vocal-loudness-worth',
-      ),
-      dict({
-      }),
-    ),
-    _Call(
-      'metadata.get().__bool__',
-      tuple(
+        2.0,
       ),
       dict({
       }),
@@ -1544,13 +1520,7 @@
       'metadata.get',
       tuple(
         'vocal-loudness-worth',
-      ),
-      dict({
-      }),
-    ),
-    _Call(
-      'metadata.get().__bool__',
-      tuple(
+        2.0,
       ),
       dict({
       }),
@@ -1684,13 +1654,7 @@
         'metadata.get',
         tuple(
           'vocal-loudness-worth',
-        ),
-        dict({
-        }),
-      ),
-      _Call(
-        'metadata.get().__bool__',
-        tuple(
+          2.0,
         ),
         dict({
         }),
@@ -1827,13 +1791,7 @@
       'metadata.get',
       tuple(
         'vocal-loudness-worth',
-      ),
-      dict({
-      }),
-    ),
-    _Call(
-      'metadata.get().__bool__',
-      tuple(
+        2.0,
       ),
       dict({
       }),