cross native and wasm, ice trickle and data channel creation #54
Conversation
There was a problem hiding this comment.
Amazing! This all looks great to me. I had a few nitpicks, and I still don't understand what exactly was different from my previous attempts at this that made this work, but maybe you do? Would be interesting to know.
I tested also tested the box_game example on chrome, firefox and windows native, and it appears to be working as expected.
I had a small hope that #36 was somehow related to ice trickle, but firefox still breaks for me after ~10 seconds, unless I have the media panel extension enabled :/
Let me know if you'd like to fix the nits yourself, or I can just merge this and do it after
Thanks again for working on this!
|
I did some further testing, and unfortunately chrome-to-chrome connections on the same machine works on the main branch, but not with this one :/ |
|
Can you provide more info on your setup and what you tried? I was able, and have been, testing mostly with chrome, and works as expected. Maybe there is a corner case I haven't seen. Box game: Our app with 3 chrome clients: |
Sorry! Turned out I was actually using an old version of |
|
Really excited to get this one in and start using it :) Great work! |
This is an attempt to get cross data communication between native and WASM WebRTC, to address #47
The screenshot shows our own app using matchbox, 2 chrome tabs, 1 firefox tab, 2 desktop (native), all communicating with each other. We also tested order of launching and making sure no matter who offers or accepts it still connects. But this is all pretty tricky and might still have some bugs.