-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add signalling utils to bevy_matchbox
#215
Conversation
For the socket i think it would probably make most sense to either support dropping the socket, or have a channel we send to that will make the future clean up and stop. |
Have opted to move the Task handle into the |
Also made the choice to remove the feature gate as target specific features are not yet supported (see: rust-lang/cargo#1197). An alternative method is to add a build script which provides an appropriate error message when someone tries to use a feature incompatible with the target, but this doesn't play particularly well with other tooling |
1f0ebeb
to
ff4eb53
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Any bevy_matchbox improvements are good to me.
@johanhelsing approval? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great :)
Adds some utils for creating a
MatchboxServer
to a bevy app as aResource
.stop_server
is currently a no-op, need to figure out how best to kill a bevy task - probably scopes. Realised this is also an issue with our regular socket behaviour