-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: bevy 0.15 #38
feat: bevy 0.15 #38
Conversation
@@ -114,7 +114,7 @@ async fn get<'a>(path: PathBuf) -> Result<Box<Reader<'a>>, AssetReaderError> { | |||
) | |||
})?; | |||
|
|||
let client = surf::Client::new().with(surf::middleware::Redirect::default()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was this change intentional?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, when surf::middleware::Redirect
is added, web_image
example errors with something like:
ERROR bevy_asset::server: Encountered an I/O error while loading asset: unexpected status code 500 while loading https://cdn.pixabay.com/photo/2015/03/10/17/23/youtube-667451_1280.png: Head byte length should be less than 8kb
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
related surf issue: http-rs/surf#289
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have encountered status code 500 but that was due to bot prevention arise from the meta check; after disabling meta check I have not had that issue.
I'm currently away from my machine; I can test our the PR later
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a feature flag for the redirect middleware. defaulting to redirect preserves the original behavior.
running the example with cargo run --example web_image --no-default-features
resolves the error.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess this is a good compromise. Wish the http client library situation in rust was better.
if loading assets without co-located bevy asset
.meta
files, disable meta loading: