Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bevy 0.15 #38

Merged
merged 4 commits into from
Jan 5, 2025
Merged

feat: bevy 0.15 #38

merged 4 commits into from
Jan 5, 2025

Conversation

mosure
Copy link
Contributor

@mosure mosure commented Dec 19, 2024

  • fixes surf native example

if loading assets without co-located bevy asset .meta files, disable meta loading:

    App::new()
        .add_plugins((
            // The web asset plugin must be inserted before the `AssetPlugin` so
            // that the AssetPlugin recognizes the new sources.
            WebAssetPlugin,
            DefaultPlugins.set(AssetPlugin {
                meta_check: bevy::asset::AssetMetaCheck::Never,
                ..default()
            }),
        ))
        .add_systems(Startup, setup)
        .run();

@@ -114,7 +114,7 @@ async fn get<'a>(path: PathBuf) -> Result<Box<Reader<'a>>, AssetReaderError> {
)
})?;

let client = surf::Client::new().with(surf::middleware::Redirect::default());
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this change intentional?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, when surf::middleware::Redirect is added, web_image example errors with something like:

ERROR bevy_asset::server: Encountered an I/O error while loading asset: unexpected status code 500 while loading https://cdn.pixabay.com/photo/2015/03/10/17/23/youtube-667451_1280.png: Head byte length should be less than 8kb

Copy link
Owner

@johanhelsing johanhelsing Dec 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was added in a recent PR (#37), @soraxas what do you think? Won't this break redirecting for you?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

related surf issue: http-rs/surf#289

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have encountered status code 500 but that was due to bot prevention arise from the meta check; after disabling meta check I have not had that issue.

I'm currently away from my machine; I can test our the PR later

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a feature flag for the redirect middleware. defaulting to redirect preserves the original behavior.

running the example with cargo run --example web_image --no-default-features resolves the error.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this is a good compromise. Wish the http client library situation in rust was better.

@johanhelsing johanhelsing merged commit fe4ee4b into johanhelsing:main Jan 5, 2025
3 checks passed
@mosure mosure deleted the feat/bevy-0.15 branch January 5, 2025 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants