cleanup and no enums

sleeper/api/_types.py

@@ -0,0 +1,5 @@
+from typing import Literal
+
+# TODO: test what is all supported in their apis
+Sport = Literal["lcs", "nba", "nfl"]
+TrendType = Literal["add", "drop"]

sleeper/api/avatar.py

@@ -1,5 +1,5 @@
-from sleeper.api.constants import AVATARS_ROUTE, SLEEPER_CDN_BASE_URL, THUMBS_ROUTE
-from sleeper.api.util import build_route, get_content
+from sleeper.api._constants import AVATARS_ROUTE, SLEEPER_CDN_BASE_URL, THUMBS_ROUTE
+from sleeper.api._utils import build_route, get_content
 
 
 def get_avatar(*, avatar_id: str, as_thumbnail: bool = False) -> bytes:

sleeper/api/draft.py

@@ -1,4 +1,4 @@
-from sleeper.api.constants import (
+from sleeper.api._constants import (
     DRAFT_ROUTE,
     DRAFTS_ROUTE,
     LEAGUE_ROUTE,
@@ -8,8 +8,8 @@
     USER_ROUTE,
     VERSION,
 )
-from sleeper.api.util import build_route, get
-from sleeper.enum.Sport import Sport
+from sleeper.api._types import Sport
+from sleeper.api._utils import build_route, get
 
 
 def get_user_drafts_for_year(*, user_id: str, sport: Sport, year: int) -> list[dict]:
@@ -19,7 +19,7 @@ def get_user_drafts_for_year(*, user_id: str, sport: Sport, year: int) -> list[d
         USER_ROUTE,
         user_id,
         DRAFTS_ROUTE,
-        sport.name.lower(),
+        sport,
         year,
     )
     return get(url)
@@ -41,7 +41,7 @@ def get_draft(*, draft_id: str) -> dict:
     return get(url)
 
 
-def get_player_draft_picks(*, draft_id: str, sport: Sport) -> list[dict]:
+def get_player_draft_picks(*, draft_id: str) -> list[dict]:
     url = build_route(
         SLEEPER_APP_BASE_URL,
         VERSION,

sleeper/api/league.py

@@ -1,4 +1,4 @@
-from sleeper.api.constants import (
+from sleeper.api._constants import (
     LEAGUE_ROUTE,
     LEAGUES_ROUTE,
     LOSERS_BRACKET_ROUTE,
@@ -13,8 +13,8 @@
     VERSION,
     WINNERS_BRACKET_ROUTE,
 )
-from sleeper.api.util import build_route, get
-from sleeper.enum import Sport
+from sleeper.api._types import Sport
+from sleeper.api._utils import build_route, get
 
 
 def get_league(*, league_id: str) -> dict:
@@ -29,7 +29,7 @@ def get_user_leagues_for_year(*, user_id: str, sport: Sport, year: int) -> list[
         USER_ROUTE,
         user_id,
         LEAGUES_ROUTE,
-        sport.value.lower(),
+        sport,
         year,
     )
     return get(url)
@@ -115,5 +115,5 @@ def get_traded_picks(*, league_id: str) -> list[dict]:
 
 
 def get_sport_state(sport: Sport) -> dict:
-    url = build_route(SLEEPER_APP_BASE_URL, VERSION, STATE_ROUTE, sport.value.lower())
+    url = build_route(SLEEPER_APP_BASE_URL, VERSION, STATE_ROUTE, sport)
     return get(url)

sleeper/api/player.py

@@ -1,22 +1,21 @@
 from typing import Optional
 
-from sleeper.api.constants import (
+from sleeper.api._constants import (
     PLAYERS_ROUTE,
     SLEEPER_APP_BASE_URL,
     TRENDING_ROUTE,
     VERSION,
 )
-from sleeper.api.util import add_filters, build_route, get
-from sleeper.enum.Sport import Sport
-from sleeper.enum.TrendType import TrendType
+from sleeper.api._types import Sport, TrendType
+from sleeper.api._utils import add_filters, build_route, get
 
 
 def get_all_players(*, sport: Sport) -> dict[str, dict]:
     url = build_route(
         SLEEPER_APP_BASE_URL,
         VERSION,
         PLAYERS_ROUTE,
-        sport.name.lower(),
+        sport,
     )
     return get(url)
 
@@ -32,9 +31,9 @@ def get_trending_players(
         SLEEPER_APP_BASE_URL,
         VERSION,
         PLAYERS_ROUTE,
-        sport.name.lower(),
+        sport,
         TRENDING_ROUTE,
-        trend_type.name.lower(),
+        trend_type,
     )
     if lookback_hours is not None:
         url = add_filters(url, ("lookback_hours", lookback_hours))

sleeper/api/user.py

@@ -1,5 +1,5 @@
-from sleeper.api.constants import SLEEPER_APP_BASE_URL, USER_ROUTE, VERSION
-from sleeper.api.util import build_route, get
+from sleeper.api._constants import SLEEPER_APP_BASE_URL, USER_ROUTE, VERSION
+from sleeper.api._utils import build_route, get
 
 
 def get_user(*, user_identifier: str) -> dict:

test/integration/test_api/test_draft.py

@@ -7,7 +7,6 @@
     get_traded_draft_picks,
     get_user_drafts_for_year,
 )
-from sleeper.enum.Sport import Sport
 from test.integration.test_api.constants import (
     LEAGUE_A_DRAFT_1,
     LEAGUE_A_DRAFT_ID_1,
@@ -24,7 +23,7 @@
 class TestDraft(unittest.TestCase):
     def test_get_user_drafts_for_year_happy_path(self):
         response = get_user_drafts_for_year(
-            user_id=USER_A_USER_ID, sport=Sport.NFL, year=2023
+            user_id=USER_A_USER_ID, sport="nfl", year=2023
         )
         self.assertEqual(USER_A_DRAFTS_2023, response)
 
@@ -37,7 +36,9 @@ def test_get_draft(self):
         self.assertEqual(LEAGUE_A_DRAFT_1, response)
 
     def test_get_player_draft_picks(self):
-        response = get_player_draft_picks(draft_id=LEAGUE_A_DRAFT_ID_1, sport=Sport.NFL)
+        response = get_player_draft_picks(
+            draft_id=LEAGUE_A_DRAFT_ID_1,
+        )
         self.assertEqual(USER_A_DRAFT_PICKS_DRAFT_ID_1_2023, response)
 
     def test_get_traded_draft_picks(self):

test/integration/test_api/test_league.py

@@ -12,7 +12,6 @@
     get_users_in_league,
     get_winners_bracket,
 )
-from sleeper.enum import Sport
 from test.integration.test_api.constants import (
     LEAGUE_A_LEAGUE,
     LEAGUE_A_LEAGUE_ID,
@@ -36,7 +35,7 @@ def test_get_league(self):
 
     def test_get_user_leagues_for_year(self):
         response = get_user_leagues_for_year(
-            user_id=USER_A_USER_ID, sport=Sport.NFL, year=2022
+            user_id=USER_A_USER_ID, sport="nfl", year=2022
         )
         self.assertEqual(USER_A_LEAGUES_2022, response)
 
@@ -73,7 +72,7 @@ def test_get_traded_picks(self):
         self.assertEqual(LEAGUE_C_TRADED_PICKS, response)
 
     def test_get_sport_state(self):
-        response = get_sport_state(sport=Sport.NFL)
+        response = get_sport_state(sport="nfl")
         # this response will constantly change, so just assert some general things
         self.assertIsInstance(response, dict)
         for k in response.keys():

test/integration/test_api/test_player.py

@@ -1,21 +1,19 @@
 import unittest
 
 from sleeper.api.player import get_all_players, get_trending_players
-from sleeper.enum.Sport import Sport
-from sleeper.enum.TrendType import TrendType
 
 
 class TestPlayer(unittest.TestCase):
     def test_get_all_players(self):
-        response = get_all_players(sport=Sport.NFL)
+        response = get_all_players(sport="nfl")
         # this response will constantly change, so just assert some general things
         self.assertIsInstance(response, dict)
         for k, v in response.items():
             self.assertIsInstance(k, str)
             self.assertIsInstance(v, dict)
 
     def test_get_trending_players(self):
-        response = get_trending_players(sport=Sport.NFL, trend_type=TrendType.ADD)
+        response = get_trending_players(sport="nfl", trend_type="add")
         # this response will constantly change, so just assert some general things
         self.assertIsInstance(response, list)
         self.assertEqual(25, len(response))

test/unit/test_api/test_draft.py

@@ -8,7 +8,6 @@
     get_traded_draft_picks,
     get_user_drafts_for_year,
 )
-from sleeper.enum.Sport import Sport
 from test.unit.helper.helper_classes import MockResponse
 
 
@@ -19,9 +18,7 @@ def test_get_user_drafts_for_year_happy_path(self, mock_requests_get):
         mock_response = MockResponse(mock_list, 200)
         mock_requests_get.return_value = mock_response
 
-        response = get_user_drafts_for_year(
-            user_id="user_id", sport=Sport.NFL, year=2020
-        )
+        response = get_user_drafts_for_year(user_id="user_id", sport="nfl", year=2020)
 
         self.assertEqual(mock_list, response)
         mock_requests_get.assert_called_once_with(
@@ -60,7 +57,7 @@ def test_get_player_draft_picks(self, mock_requests_get):
         mock_response = MockResponse(mock_dict, 200)
         mock_requests_get.return_value = mock_response
 
-        response = get_player_draft_picks(draft_id="12345", sport=Sport.NFL)
+        response = get_player_draft_picks(draft_id="12345")
 
         self.assertEqual(mock_dict, response)
         mock_requests_get.assert_called_once_with(

test/unit/test_api/test_league.py

@@ -13,7 +13,6 @@
     get_users_in_league,
     get_winners_bracket,
 )
-from sleeper.enum import Sport
 from test.unit.helper.helper_classes import MockResponse
 
 
@@ -37,9 +36,7 @@ def test_get_user_leagues_for_year(self, mock_requests_get):
         mock_response = MockResponse(mock_list, 200)
         mock_requests_get.return_value = mock_response
 
-        response = get_user_leagues_for_year(
-            user_id="12345", sport=Sport.NFL, year=2024
-        )
+        response = get_user_leagues_for_year(user_id="12345", sport="nfl", year=2024)
 
         self.assertEqual(mock_list, response)
         mock_requests_get.assert_called_once_with(
@@ -143,7 +140,7 @@ def test_get_sport_state(self, mock_requests_get):
         mock_response = MockResponse(mock_dict, 200)
         mock_requests_get.return_value = mock_response
 
-        response = get_sport_state(sport=Sport.NFL)
+        response = get_sport_state(sport="nfl")
 
         self.assertEqual(mock_dict, response)
         mock_requests_get.assert_called_once_with(

test/unit/test_api/test_player.py

@@ -2,8 +2,6 @@
 from unittest.mock import patch
 
 from sleeper.api.player import get_all_players, get_trending_players
-from sleeper.enum.Sport import Sport
-from sleeper.enum.TrendType import TrendType
 from test.unit.helper.helper_classes import MockResponse
 
 
@@ -14,7 +12,7 @@ def test_get_all_players(self, mock_requests_get):
         mock_response = MockResponse(mock_dict, 200)
         mock_requests_get.return_value = mock_response
 
-        response = get_all_players(sport=Sport.NFL)
+        response = get_all_players(sport="nfl")
 
         self.assertEqual(mock_dict, response)
         mock_requests_get.assert_called_once_with(
@@ -27,7 +25,7 @@ def test_get_trending_players_with_defaults(self, mock_requests_get):
         mock_response = MockResponse(mock_list, 200)
         mock_requests_get.return_value = mock_response
 
-        response = get_trending_players(sport=Sport.NFL, trend_type=TrendType.ADD)
+        response = get_trending_players(sport="nfl", trend_type="add")
 
         self.assertEqual(mock_list, response)
         mock_requests_get.assert_called_once_with(
@@ -41,7 +39,7 @@ def test_get_trending_players_with_optional_params_given(self, mock_requests_get
         mock_requests_get.return_value = mock_response
 
         response = get_trending_players(
-            sport=Sport.NFL, trend_type=TrendType.ADD, lookback_hours=1, limit=2
+            sport="nfl", trend_type="add", lookback_hours=1, limit=2
         )
 
         self.assertEqual(mock_list, response)