Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Routes with outlets inside of lazy module #42

Open
diogolPereira opened this issue Apr 28, 2020 · 7 comments
Open

Routes with outlets inside of lazy module #42

diogolPereira opened this issue Apr 28, 2020 · 7 comments

Comments

@diogolPereira
Copy link

diogolPereira commented Apr 28, 2020

I have a problem with routes with outlets inside a lazyloading module.

APP1Routing module:

const routes: Routes = [
  {
    path:'app1',
    children:[
      {path:'child',component:ChildComponent},
      {path:'outlet',outlet:'example',component:OutletComponent},
      {path:'lazy',
      loadChildren:()=>import('./lazy/lazy.module').then(m => m.LazyModule)
      },
    ]
  },
  { path: '**', component: EmptyRouteComponent },

];

LazyModule routing:

const routes: Routes = [`
  {
    path:'',
    component:LazyComponent,
    children:[
      {path:'child',component:ChildLazyComponent},
      {path:'outlet',
       outlet:'example',
       component:OutletLazyComponent},
    ]
  },

];

Console don't display errors or warnings.

Ps: I create one fork with the example (https://github.com/diogolPereira/coexisting-angular-microfrontends).

@diogolPereira diogolPereira changed the title Routes with outlets inside of lazy module is broken Routes with outlets inside of lazy module Apr 30, 2020
@diogolPereira
Copy link
Author

someone have any news related to that issue

@joeldenning
Copy link
Owner

I took a quick look at this and didn't make it very far. Angular isn't my strength. @arturovt do you have time to look at this?

@diogolPereira
Copy link
Author

Did you have some more information about that ? @arturovt @joeldenning

@diogolPereira
Copy link
Author

someone have any news related to that issue @joeldenning

@joeldenning
Copy link
Owner

joeldenning commented Sep 11, 2020

I no longer spend much time helping maintain single-spa-angular, leaving it for others to maintain. There are a few people helping maintain it - I am not sure when they'll have time to look at this. The reason I've stopped putting a lot of time into maintaining it is that I don't know Angular well and single-spa-angular consumes more time than the combined time I spend on single-spa, single-spa-react, single-spa-vue, and all other single-spa libraries. The time I spent on single-spa-angular was often long and frustrating, so I've taken a step back.

@joeldenning
Copy link
Owner

One thing to note is that it might be best to reopen this issue on single-spa-angular instead of this example repo - the single-spa-angular repo is where we track angular-related issues.

@diogolPereira
Copy link
Author

@joeldenning thanks for feedback i will reopen the issue in single-spa-angular

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants