Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Routes with outlets inside of lazy module #276

Closed
diogolPereira opened this issue Sep 14, 2020 · 3 comments
Closed

Routes with outlets inside of lazy module #276

diogolPereira opened this issue Sep 14, 2020 · 3 comments

Comments

@diogolPereira
Copy link

I have a problem with routes with outlets inside a lazyloading module.

When i have childrens-routes with outles inside a lazyloading module single-spa can't interpret the route and stay in the parent route.

Demonstration

APP1Routing module:

const routes: Routes = [
  {
    path:'app1',
    children:[
      {path:'child',component:ChildComponent},
      {path:'outlet',outlet:'example',component:OutletComponent},
      {path:'lazy',
      loadChildren:()=>import('./lazy/lazy.module').then(m => m.LazyModule)
      },
    ]
  },
  { path: '**', component: EmptyRouteComponent },

];

LazyModule routing:

const routes: Routes = [`
  {
    path:'',
    component:LazyComponent,
    children:[
      {path:'child',component:ChildLazyComponent},
      {path:'outlet',
       outlet:'example',
       component:OutletLazyComponent},
    ]
  },

];

Console don't display errors or warnings.

I create one fork with the example (https://github.com/diogolPereira/coexisting-angular-microfrontends).

Expected Behaviour

Single-spa can interpret the angular routes with children's inside of lazy modules.

P.s: Original issue (joeldenning/coexisting-angular-microfrontends#42)

@JohnnyHonorato
Copy link

Any news about this problem? I'm with the same

@joeldenning
Copy link
Member

I don't spend much time maintaining single-spa-angular, and there aren't many other maintainers who help with it. I review pull requests and try to encourage others to help maintain single-spa-angular, but don't have time to go through all the issues.

@arturovt
Copy link
Member

I haven’t found any way to make this working, unfortunately. Outlets have been always problematic to deal with since it’s like an “addition” to the classic router behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants