-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[New New UI] Disable blurred bg behind image previews, hide post separators and add features to Custom Feed #109
base: main
Are you sure you want to change the base?
Conversation
- [New New UI] Add an option under Hide Elements to hide post separators in feeds. As an extra touch, add .75rem padding to posts to compensate bad paddings (thx Reddit for using Tailwind incorrectly). LMK if this needs to be changed or customisable - [New New UI] Add an option under Hide Elements to hide background blur behind image previews, which hopefully should help with low-end devices. Video and GIF players are not affected (sadly). - [New New UI] Fix an issue where post border may appear in post view and mod queue. Post border should only be shown in feeds... I believe
This comment was marked as resolved.
This comment was marked as resolved.
If Hide the Side Menu/Side Menu Toggle Button is on and the viewport is less than 1200px, Reddit will attempt to "hide" the side menu itself, which moves #main-content to first grid column and causes grid-template-column to break. Also include changes to line-height when resizing fonts
Why does Hide the Side Menu and Side Menu Toggle Button use the same HTML class?? Also increase the limit of Side Menu Width to 500px because, you know, perverted stuff.
…has actual flairs Reddit API output post flairs in the form of an array. Fix a problem where shreddit-post-flair is added to posts with no flairs, causing really weird paddings
…en post has actual flairs" This reverts commit 324ecf6.
- Fix an issue where post title font size change doesn't affect x-posted posts in search results - Reduce inconsistencies when using Theme Border Radius; only rounding known elements outside shadowRoot (this should cover around 80% of all elements) - some really minor tweaks
…l screen width Bring back the Old New UI style banner for New New UI. To facilitate the new width, .subgrid-container width has to be set to 100% while keeping main-content at its OG size.
…post paddings from Custom Background Hide Post Divider will cover that.
- Add option to turn on compact rule list that mimics Old New UI rule list for subreddit sidebar - Add option to turn on compact 48px header and padding removed side menu - Add option to resize entire main container rather than main-content (experimental) - Minor fix for border radius and full width banner on subreddit wiki pages - Minor fix for hover author card on front page and show post author on custom feeds
…or tweaks - x-posted post content font size can now be changed - Smaller margins between posts for compact subreddit vuew - Reduce paddings for lists in right sidebar - Post Insights panel is now transparent and reflects overall post background colour
…ead lines" Accidentally pushed package.json and package-lock.json again... This reverts commit b249610.
This is great, thanks! I've just replied to your post on Reddit. |
Awesome. I'll be on the lookout for it and make changes as necessary. It might take some time though, probably in the next couple of weeks—have to prioritise some work first! Also I've been noticing that many features are CSS patches, so I wonder if it might be possible for a v2 rewrite with CSS code being in a couple of files, and we use JS to toggle features with CSS classes and variables, with some JS-exclusive features. Makes the code a lot cleaner, but I understand there would be a problem with the extension stores. Hopefully after this I can try to focus more on the bugs & feature requests. If it's okay, I'll bring back some more features from Old New UI as well. |
Reddit intends post view to be a single card, do not separate that into 3 smaller pills
No worries man, no rush. I appreciate your help with all this.
This is how I initially had it actually, but the file was monolithic and I was tired of scrolling up and down trying to find sections to edit. I thought that dynamically creating and removing stylesheets would be easier to maintain, and would also reduce unnecessary code loaded on the webpage. Although thinking about it now, I could keep the css in the javascript files for each feature as variables, then when webpack builds, it could import all the css from each feature into one main css file the page will load. This would make it easy to maintain, but the page would still load all the css for all the features. I suppose it wouldn't be too big. I'll do some testing.
Sounds good, thanks :) Regarding the conflicts, I renamed some of the files and folders. I replaced "-" with "_" in some names, looks better. "content > functions" --> "content > tweaks" Also, for every option input it sends a message to the popup_listener with this code:
To optimise the code and make it cleaner, I turned this into a function. You can now call it like this:
|
In case you need something for the changelog later:
[NEW FEATURES]
[BUG FIXES & TWEAKS]
Font Size Change is not reflected on Profile page in new new reddit. #99
Already addressed in #107 and #108:
Long letters cut off when resizing post titles #97 Changing font size incorrectly changes line height #103
[TODO]
~ tested on Firefox 133.0.3, Windows 11 ~