♻️ (eslint) disallow unnecessary curly braces (actualbudget#2111)

joel-jeremy · Dec 22, 2023 · 73d281b · 73d281b
1 parent 03e943f
commit 73d281b
Show file tree

Hide file tree

Showing 8 changed files with 16 additions and 9 deletions.
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -97,6 +97,7 @@ module.exports = {
     // ],
 
     'no-var': 'warn',
+    'react/jsx-curly-brace-presence': 'warn',
     'object-shorthand': ['warn', 'properties'],
 
     'import/extensions': [

diff --git a/packages/desktop-client/src/components/filters/FiltersButton.tsx b/packages/desktop-client/src/components/filters/FiltersButton.tsx
@@ -9,7 +9,7 @@ type FiltersButtonProps = {
 
 function FiltersButton({ onClick }: FiltersButtonProps) {
   return (
-    <Button type="bare" onClick={onClick} title={'Filters'}>
+    <Button type="bare" onClick={onClick} title="Filters">
       <SettingsSliderAlternate
         style={{ width: 16, height: 16, marginRight: 5 }}
       />{' '}

diff --git a/packages/desktop-client/src/components/reports/ReportTableHeader.tsx b/packages/desktop-client/src/components/reports/ReportTableHeader.tsx
@@ -73,15 +73,15 @@ export default function ReportTableHeader({
                     minWidth: 85,
                     ...styles.tnum,
                   }}
-                  value={'Deposits'}
+                  value="Deposits"
                   width="flex"
                 />
                 <Cell
                   style={{
                     minWidth: 85,
                     ...styles.tnum,
                   }}
-                  value={'Payments'}
+                  value="Payments"
                   width="flex"
                 />
               </>
@@ -91,15 +91,15 @@ export default function ReportTableHeader({
             minWidth: 85,
             ...styles.tnum,
           }}
-          value={'Totals'}
+          value="Totals"
           width="flex"
         />
         <Cell
           style={{
             minWidth: 85,
             ...styles.tnum,
           }}
-          value={'Average'}
+          value="Average"
           width="flex"
         />
         {scrollWidth > 0 && <Cell width={scrollWidth} />}

diff --git a/packages/desktop-client/src/components/reports/ReportTableTotals.tsx b/packages/desktop-client/src/components/reports/ReportTableTotals.tsx
@@ -57,7 +57,7 @@ export default function ReportTableTotals({
             minWidth: 125,
             ...styles.tnum,
           }}
-          value={'Totals'}
+          value="Totals"
           width="flex"
         />
         {mode === 'time'

diff --git a/packages/desktop-client/src/components/reports/SaveReport.tsx b/packages/desktop-client/src/components/reports/SaveReport.tsx
@@ -62,7 +62,7 @@ export function SaveReportMenuButton() {
             flexShrink: 0,
           }}
         >
-          {'Unsaved Report'}&nbsp;
+          Unsaved Report&nbsp;
         </Text>
         <ExpandArrow width={8} height={8} style={{ marginRight: 5 }} />
       </Button>

diff --git a/packages/desktop-client/src/components/reports/graphs/BarGraph.tsx b/packages/desktop-client/src/components/reports/graphs/BarGraph.tsx
@@ -198,7 +198,7 @@ function BarGraph({
                   ))}
                 </Bar>
                 {yAxis === 'date' && balanceTypeOp === 'totalTotals' && (
-                  <Bar dataKey={'totalDebts'} stackId="a">
+                  <Bar dataKey="totalDebts" stackId="a">
                     {data[splitData].map((entry, index) => (
                       <Cell
                         key={`cell-${index}`}

diff --git a/packages/desktop-client/src/components/reports/graphs/StackedBarGraph.tsx b/packages/desktop-client/src/components/reports/graphs/StackedBarGraph.tsx
@@ -77,7 +77,7 @@ const CustomTooltip = ({ active, payload, label }: CustomTooltipProps) => {
                   );
                 })}
               <AlignedText
-                left={'Total'}
+                left="Total"
                 right={amountToCurrency(sumTotals)}
                 style={{
                   fontWeight: 600,

diff --git a/upcoming-release-notes/2111.md b/upcoming-release-notes/2111.md
@@ -0,0 +1,6 @@
+---
+category: Maintenance
+authors: [MatissJanis]
+---
+
+eslint: disallow unnecessary curly braces