🐛 (autocomplete) fix multi-autocomplete causing crashes (actualbudget…

…#2207)
joel-jeremy · Jan 10, 2024 · 3eee0b1 · 3eee0b1
1 parent e792afb
commit 3eee0b1
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 6 deletions.
diff --git a/packages/desktop-client/src/components/autocomplete/Autocomplete.tsx b/packages/desktop-client/src/components/autocomplete/Autocomplete.tsx
@@ -31,16 +31,12 @@ function findItem<T extends Item>(
   strict: boolean,
   suggestions: T[],
   value: T | T['id'],
-): T | null {
+): T | T['id'] | null {
   if (strict) {
     const idx = suggestions.findIndex(item => item.id === value);
     return idx === -1 ? null : suggestions[idx];
   }
 
-  if (typeof value === 'string') {
-    throw new Error('value can be string only if strict = false');
-  }
-
   return value;
 }
 
@@ -302,7 +298,7 @@ function SingleAutocomplete<T extends Item>({
         }
       }}
       highlightedIndex={highlightedIndex}
-      selectedItem={selectedItem || null}
+      selectedItem={selectedItem instanceof Object ? selectedItem : null}
       itemToString={itemToString}
       inputValue={value}
       isOpen={isOpen}

diff --git a/upcoming-release-notes/2207.md b/upcoming-release-notes/2207.md
@@ -0,0 +1,6 @@
+---
+category: Bugfix
+authors: [MatissJanis]
+---
+
+Fix multi-autocomplete in rules page causing crashes