Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update NDR channels #570

Merged
merged 1 commit into from
Jun 2, 2022
Merged

Conversation

poika-xy
Copy link
Contributor

Fixes HLS stream URLs

@bjoerns1983
Copy link
Collaborator

Would you mind using the generice master.m3u8 instead of the master_720.m3u8?
So the client could switch between the different resolutions depending on the network speed.

@poika-xy
Copy link
Contributor Author

poika-xy commented May 27, 2022

Personally, I do prefer the master.m3u8 too.
In #406 (comment) it said:
direct high quality streams > master streams* (eg. index_3096_av-p.m3u8 vs master.m3u8)
and
*The reason for this have been the faster channel switches in the past. This however requires frequent changes to stream URLs as most of you have seen in the past. The 'master' link should be working even when a direct stream URL would have to be changed.

Therefore I extracted the highest resolution stream.

Could one of the maintainers please state a clear policy (on which .m3u8 URL to choose) in either:
https://github.com/jnk22/kodinerds-iptv/blob/master/CONTRIBUTING.md
or
https://github.com/jnk22/kodinerds-iptv/blob/master/README.md

Edit:
Of course I know some broadcasters might make it quite hard to extract only the high quality stream, i.e. newer HLS/m3u8 standards, separate the audio and video streams their master.m3u8. In these cases the master.m3u8 will become the only reasonable solution.

Concerning the comments from the issue: "The reason for this have been the faster channel switches in the past." could be addressed easily if the underlying software (kodi?) would probe the IPTV streams in background and cache the video and audio streams, available in the master.m3u8. (To me it seems that VLC and ffplay/ffmpeg sometimes take quite a long time to start playback since they seem to test playback of all streams and then select the highest quality streams... But I could be mistaken)

@jnk22
Copy link
Owner

jnk22 commented May 29, 2022

@poika-xy You are right, this has not been properly defined before. I have created a PR with an updated CONTRIBUTING.md file: #571

@bjoerns1983
Copy link
Collaborator

Okay should be clear now.
@poika-xy would you add the master.m3u8 links or should i do that?

@poika-xy
Copy link
Contributor Author

poika-xy commented Jun 1, 2022

@bjoerns1983, I'll do it now.

@poika-xy poika-xy force-pushed the fix_channels_ndr branch from 78a88a4 to 685f7c3 Compare June 1, 2022 18:49
@poika-xy
Copy link
Contributor Author

poika-xy commented Jun 1, 2022

Ok, everything should be ready to merge. All stream URLs were tested.

@jnk22 @bjoerns1983 Thank you for adding clarifying statements :)

@bjoerns1983 bjoerns1983 merged commit 9cc3d75 into jnk22:master Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants