Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added option to remove rank/file labels #16

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

JeffML
Copy link

@JeffML JeffML commented Feb 1, 2020

Unfortunately there are code format changes, so I'll explain here:

  1. added a boolean labels prop; if true, behavior is same as now
  2. if false:
    1. the labels are not shown
    2. the board and pieces are shifted over (no left padding)
    3. the board size is adjusted (no right padding)
  3. added an input control to the demo
    1. note that there is an existing bug for both flip (and now label) checkboxes : it will only re-render when checkbox is toggled twice
  4. not fixed: the piece selection square is now off-by-one; I'm not using this and will probably not get around to fixing it
  5. also added package.lock.json to repo
  6. npm audit reveals lots of issues, but I did not try to fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant