Dead stores should be removed #122
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -219,7 +219,7 @@ public KeyValue getKeyValue(String KeyURI) throws EmbeddedJmxTransException { | |||
| } | |||
|
|
|||
| private URL[] makeEtcdBaseUris(String etcdURI) throws EmbeddedJmxTransException { | |||
| String serverList = null; | |||
| String serverList; | |||
There was a problem hiding this comment.
This is probably a good candidate for a method extraction and the removal of the conditional assignment. This would IMHO bring more clarity than just removing the dead store.
|
@AymanDF sorry but I prefer to let the author of the code decide of the style of the code for things such as initialization to zero as I personally think that it helps readability. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is focused on resolving occurrences of Sonar rule squid:S1854 - “ Dead stores should be removed ”. You can find more information about the issue here:
https://dev.eclipse.org/sonar/rules/show/squid:S1854
Please let me know if you have any questions.
Ayman Abdelghany.