Add some javadocs, plus more precisely narrow where an exception is c…

…aught.
jmxt3 · Jun 28, 2013 · 525cb97 · 525cb97
1 parent ec9c6be
commit 525cb97
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 3 deletions.
diff --git a/core/src/main/java/dagger/internal/FailoverLoader.java b/core/src/main/java/dagger/internal/FailoverLoader.java
@@ -32,13 +32,14 @@ public final class FailoverLoader implements Loader {
    * Obtains a module adapter for {@code module} from the first responding resolver.
    */
   @Override public <T> ModuleAdapter<T> getModuleAdapter(Class<? extends T> type, T instance) {
+    ModuleAdapter<T> result = null;
     try {
-      ModuleAdapter<T> result = GeneratedAdapters.initModuleAdapter(type);
-      result.module = (instance != null) ? instance : result.newModule();
-      return result;
+      result = GeneratedAdapters.initModuleAdapter(type);
     } catch (ClassNotFoundException e) {
       throw new TypeNotPresentException(type + GeneratedAdapters.MODULE_ADAPTER_SUFFIX, e);
     }
+    result.module = (instance != null) ? instance : result.newModule();
+    return result;
   }
 
   @Override public Binding<?> getAtInjectBinding(String key, String className,

diff --git a/core/src/main/java/dagger/internal/loaders/GeneratedAdapters.java b/core/src/main/java/dagger/internal/loaders/GeneratedAdapters.java
@@ -35,16 +35,28 @@ public final class GeneratedAdapters {
 
   private GeneratedAdapters() { }
 
+  /**
+   * Attempts to load an adapter named from the provided type plus a constant suffix
+   * {@link #MODULE_ADAPTER_SUFFIX}, or throws a ClassNotFoundException.
+   */
   public static <T> ModuleAdapter<T> initModuleAdapter(Class<? extends T> moduleClass)
       throws ClassNotFoundException {
     return instantiate(moduleClass.getName() + MODULE_ADAPTER_SUFFIX, moduleClass.getClassLoader());
   }
 
+  /**
+   * Attempts to load an adapter named from the provided class name plus a constant suffix
+   * {@link #INJECT_ADAPTER_SUFFIX}, or throws a ClassNotFoundException.
+   */
   public static Binding<?> initInjectAdapter(String className, ClassLoader classLoader)
       throws ClassNotFoundException {
     return instantiate(className + INJECT_ADAPTER_SUFFIX, classLoader);
   }
 
+  /**
+   * Attempts to load an adapter named from the provided type plus a constant suffix
+   * {@link #STATIC_INJECTION_SUFFIX}, or throws a ClassNotFoundException.
+   */
   public static StaticInjection initStaticInjection(Class<?> injectedClass)
       throws ClassNotFoundException {
     return instantiate(injectedClass.getName() + STATIC_INJECTION_SUFFIX,