Merge pull request piggz#380 from jmlich/dialog-via-acceptdestination

[kirigami] DatePicker dialog doesn't pop() when accepted
jmlich · Nov 22, 2024 · dbd7a48 · dbd7a48
2 parents 5d07488 + 886829f
commit dbd7a48
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 11 deletions.
diff --git a/ui/qml/components/platform.kirigami/DialogPL.qml b/ui/qml/components/platform.kirigami/DialogPL.qml
@@ -38,9 +38,9 @@ PagePL {
             if (acceptDestinationPop)
                 app.pages.pop(acceptDestination);
             else
-                app.push(acceptDestination);
-        } //else
-            //app.pages.pop();
+                app.pages.push(acceptDestination);
+        } else
+            app.pages.pop();
     }
 
     function accept() {

diff --git a/ui/qml/components/platform.qtcontrols/DialogPL.qml b/ui/qml/components/platform.qtcontrols/DialogPL.qml
@@ -41,7 +41,7 @@ PagePL {
             if (acceptDestinationPop)
                 app.pages.pop(acceptDestination);
             else
-                app.push(acceptDestination);
+                app.pages.push(acceptDestination);
         } else
             app.pages.pop();
     }

diff --git a/ui/qml/pages/FirstPage.qml b/ui/qml/pages/FirstPage.qml
@@ -11,21 +11,18 @@ PagePL {
 
     function unpairAccepted() {
         DaemonInterfaceInstance.disconnect();
-        app.pages.push(Qt.resolvedUrl("./PairSelectDeviceType.qml"));
     }
 
     pageMenu: PageMenuPL {
         PageMenuItemPL {
             text: qsTr("Pair with watch")
             onClicked: {
-                var page = AmazfishConfig.pairedAddress
-                        ? "UnpairDeviceDialog.qml"
-                        : "PairSelectDeviceType.qml"
-
-                var obj = app.pages.push(Qt.resolvedUrl(page));
-
                 if (AmazfishConfig.pairedAddress) {
+                    var obj = app.pages.push(Qt.resolvedUrl("UnpairDeviceDialog.qml"));
+                    obj.acceptDestination = Qt.resolvedUrl("PairSelectDeviceType.qml")
                     obj.accepted.connect(unpairAccepted);
+                } else {
+                    app.pages.push(Qt.resolvedUrl("PairSelectDeviceType.qml"));
                 }
             }
         }