Added EventEmitter support

[galenwp]

Made Collate extend EventEmitter and emit events at the appropriate times so the class can be used inside a running server more easily.

[jmlewis]

Did you merge the latest collate changes? I see this pull request as not able to be automatically merged.

On Dec 28, 2012, at 11:54 PM, Galen Wolfe-Pauly [email protected] wrote:

Made Collate extend EventEmitter and emit events at the appropriate times so the class can be used inside a running server more easily.

You can merge this Pull Request by running:

git pull https://github.com/galenwp/collate master
Or view, comment on, or merge it at:

#4

Commit Summary

• Beta EventEmitter support
File Changes

• M lib/collate.js (33)
• M src/collate.coffee (14)
Patch Links

• https://github.com/jmlewis/collate/pull/4.patch
• https://github.com/jmlewis/collate/pull/4.diff
—
Reply to this email directly or view it on GitHub.

[galenwp]

Whoops, will do and re send

On Dec 29, 2012, at 12:17 PM, Joshua Lewis wrote:

Did you merge the latest collate changes? I see this pull request as not able to be automatically merged.

Josh

On Dec 28, 2012, at 11:54 PM, Galen Wolfe-Pauly [email protected] wrote:

Made Collate extend EventEmitter and emit events at the appropriate times so the class can be used inside a running server more easily.

You can merge this Pull Request by running:

git pull https://github.com/galenwp/collate master
Or view, comment on, or merge it at:

#4

Commit Summary

• Beta EventEmitter support
File Changes

• M lib/collate.js (33)
• M src/collate.coffee (14)
Patch Links

• https://github.com/jmlewis/collate/pull/4.patch
• https://github.com/jmlewis/collate/pull/4.diff
—
Reply to this email directly or view it on GitHub.

—
Reply to this email directly or view it on GitHub.

[galenwp]

Events are only emitted in verbose mode. Is that the best way to do it? If being used from the CLI it probably doesn't matter if the events are being emitted, and the emit calls could happen whether in verbose mode or not.

Thoughts?

[jmlewis]

I think it should always emit events since you can choose whether to listen to them.

On Dec 29, 2012, at 4:27 PM, Galen Wolfe-Pauly [email protected] wrote:

Events are only emitted in verbose mode. Is that the best way to do it? If being used from the CLI it probably doesn't matter if the events are being emitted, and the emit calls could happen whether in verbose mode or not.

Thoughts?

—
Reply to this email directly or view it on GitHub.