Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc tweaks #11

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Misc tweaks #11

wants to merge 3 commits into from

Conversation

kornelski
Copy link

  • Modules don't need to exist as (tiny) files.
  • Enums without a non-exhaustive attribute may as well be changed to be copyable.
  • to_vec copies, but into can reuse existing allocation.
  • It'd be nice to change &self to self on execute to avoid copying in other cases.

@jmgilman
Copy link
Owner

Thanks for the PR, looks like some tests are failing. I can try to look into this more in-depth next week.

@kornelski
Copy link
Author

Yeah, these tests print "wip" for me, so I assume that's something unrelated unfinished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants