Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a possibility to use different OTP apps #6

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ihorkatkov
Copy link

There is a case, when different otp apps inside umbrella needs to use the library. The PR adds an option to configure it basing on an OTP app.

Like so:

config :my_app, Ueberauth.Strategy.ADFS.OAuth,
  adfs_url: System.get_env("ADFS_URL"),
  adfs_handler: MyApp.ADFSHandler, # Optional, ability to provide handler to extract information from the token claims
  client_id: System.get_env("ADFS_CLIENT_ID"),
  resource_identifier: System.get_env("RESOURCE_IDENTIFIER")

config :my_app, Ueberauth,
providers: [
  adfs: { Ueberauth.Strategy.ADFS,
    [
      otp_app: :my_app
      #uid_field: :email,
      #request_path: "/auth/adfs",
      #callback_path: "/auth/adfs/callback"
    ]
  }
]

@ihorkatkov
Copy link
Author

The reason it has conflicts is that we use 0.2.0 version of the library. If you want to use the functionality, feel free to use the branch and rebase on the master. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant