-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Logging to support catching errors #54
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for foyle canceled.
|
…or all our protos
…en't getting set.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Logging to support #7
Updated logging in Agent.Generate and Executor.Execute so we log the information needed to determine when the human edits the cell
To properly log protos in structured logging we need to use the zapr proto plugin to generate MarshalLogObject functions for all the protos. We can then use
zap.Object
to pass the protos as fields to loggerAdd a logs subcommand and analyzer to process the logs and join the log entries into traces and logs for the blocks
Log call stack; fix Logs no longer include call stack #53; this was broken when we stopped using the helper functions to build the logs. Now that we explicitly build the logger we need to add the option to log the call stack.
Altered the
SetupLogging
method inapp/cmd/assets.go
to accept alogToFile
boolean parameter, allowing conditional logging to files. We only want the serve command to log to files. We don't need the other commands to log to filesAnalysis Package (
app/pkg/analyze
):analyze
, responsible for processing and analyzing log files. This includes parsing raw log entries, organizing them into traces and blocks, and producing structured summaries that highlight the execution flow and outcomes.LogEntry
,Trace
,BlockLog
, etc.) to facilitate the analysis and organization of logs.Configuration and Utility Changes:
app/pkg/config/config.go
to include methods for retrieving both raw and processed log directories, supporting the new logging mechanism.app/pkg/docs/outputs.go
to extract specific metadata from logged blocks, such as execution exit codes.