fix: Correct API endpoint and adjust localhost configuration (Resolves #346) #349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ocalhost. - Updated endpoint path from `foyle.logs.SessionsService/GetSession` to `api/GetSession`. - Added a period after `jq` for proper JSON parsing. - Replaced `https://` with `http://` for localhost to avoid unnecessary SSL complications.
![standard-input[bot]](https://avatars.githubusercontent.com/in/1011034?s=60&v=4){kind=small}
✅ Deploy Preview for foyle ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
jlewi
reviewed
Nov 25, 2024
|
Thank you so much for this; one minor suggestion. |
|
Thanks for pointing that out! I’ll update the code |
jlewi
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title
fix: Correct API endpoint and adjust localhost configuration (Resolves #346)
Description:
This pull request addresses the following issues related to the API call and local development setup:
• API Endpoint Fix: Updated the endpoint path from foyle.logs.SessionsService/GetSession to api/GetSession for proper routing.
• jq Syntax Correction: Added a period (.) after jq to ensure JSON output is parsed and displayed correctly.
• Protocol Adjustment: Replaced https:// with http:// for localhost to avoid unnecessary SSL complications during local testing.
Before
After
Closes Issue: #346