Fix empty doc generation. #308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* In 14 of our 424 examples in evaluation the input document sent to the model ends up being the empty string * This is the result of how our doc tailer works. Our doc tailer imposes a length cap on the tail of the document. There was a bug in the tailer where if the last cell in the document exceeded the cap (currently 1110 characters) then an empty string would be returned. * This PR fixes that. If the last cell exceeds the length then we take the tail of that cell. * This PR also checks in completer that the tail of the document is non empty; if its not empty then we fail the completion rather than continuing to generate the completion. * Fix #305
✅ Deploy Preview for foyle canceled.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 14 of our 424 examples in evaluation the input document sent to the model ends up being the empty string
This is the result of how our doc tailer works. Our doc tailer imposes a length cap on the tail of the document. There was a bug in the tailer where if the last cell in the document exceeded the cap (currently 1110 characters) then an empty string would be returned.
This PR fixes that. If the last cell exceeds the length then we take the tail of that cell.
This PR also checks in completer that the tail of the document is non empty; if its not empty then we fail the completion rather than continuing to generate the completion.
Add a level1 assertion so we can measure how often we include less than 1 full cell in the prompt.
Fix Suggestions stop being generated when linger on a cell - Empty String Used For Completion #305