Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(translations): update Simplified Chinese Strings #197

Merged
merged 3 commits into from
Dec 31, 2023

Conversation

sr093906
Copy link

No description provided.

@jkuester jkuester self-requested a review December 30, 2023 13:38
Copy link
Owner

@jkuester jkuester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I added a couple minor questions/comments inline. Most importiantly, I would like to make sure we get the proper date format set!

app/src/main/res/values-zh-rCN/strings.xml Outdated Show resolved Hide resolved
app/src/main/res/values-zh-rCN/strings.xml Outdated Show resolved Hide resolved
app/src/main/res/values-zh-rCN/strings.xml Outdated Show resolved Hide resolved
@jkuester jkuester added this to the 2.1.0 milestone Dec 30, 2023
@sr093906
Copy link
Author

@jkuester Hi, I removed lines where there are 'false' label and reverted the date string back to unchanged. Hope this will solve the issues mentioned. Thanks and an early Happy New Year from UTC+8.

Copy link
Owner

@jkuester jkuester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

And Happy New Year @sr093906!

@jkuester jkuester changed the title Update Simplified Chinese Strings feat(translations): update Simplified Chinese Strings Dec 31, 2023
@jkuester jkuester merged commit 053bb2d into jkuester:master Dec 31, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants