Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(#103): make hidden apps findable with search #130

Merged
merged 3 commits into from
Dec 26, 2023

Conversation

JuanJakobo
Copy link

@JuanJakobo JuanJakobo commented Sep 30, 2022

Hi jkuester,
Thanks for the great app!
I created a method to enable in the settings the option to search all apps (shown and hidden).
Hope it is the correct way to do it.

closes #103

@JuanJakobo JuanJakobo marked this pull request as ready for review September 30, 2022 11:34
@jkuester
Copy link
Owner

@JuanJakobo I am sorry for the delayed response here! Could you help me understand the rational behind this feature? It seems like if you want to see all the apps in the drawer, then just do not hide any of the apps via the "Visible Apps" menu. If you also want to see the pinned "home apps" in the drawer, these are hidden by default when you pin them to the home screen. But, you can actually use the "Visible Apps" menu and re-check them so they are displayed in the drawer again (and are searchable).

But, maybe I am missing what you are trying to do here! 🤔

@JuanJakobo
Copy link
Author

Hi,
the idea here is that you can hide apps as you said via the "Visible Apps", but you might still want to search all apps. For example I hide some apps from the drawer as the list gets to crowed. This app for example could be WhatsApp. I still want to use WhatsApp and going to the apps overview in Android Settings just to open the app is a bit to much work. Therefore I would like to search for it using the "Search Bar" above the drawer. So the App is hidden from the drawer itself, but it will appear in the search results.

Hope that makes it clear. 😄

@C4yrslf
Copy link

C4yrslf commented Sep 3, 2023

I wholeheartedly agree with JuanJakobo. On the pixel 6a, the drawer can fit about 19 apps which is good. But excluding the apps on the home screen, I have maybe25 apps that should be in the drawer.

What happens then is the drawer can be scrolled. This is, for me, a small irritation sometimes as I use my phone mostly with muscle memory and I can't for the apps in the drawer as with the scrolling feature, apps are not always at the location on the screen.

The solution for this is to be able to search all apps with the search function. It keeps the drawer organized and clean while still allowing access to all apps, including those I decided not to put in the drawer for the reason mentionned above.

I love this app, thank you.

# Conflicts:
#	app/src/main/java/com/sduduzog/slimlauncher/adapters/AppDrawerAdapter.kt
#	app/src/main/java/com/sduduzog/slimlauncher/datasource/coreprefs/CorePreferencesRepository.kt
#	app/src/main/java/com/sduduzog/slimlauncher/ui/main/HomeFragment.kt
#	app/src/main/java/com/sduduzog/slimlauncher/ui/options/CustomizeAppDrawerFragment.kt
#	app/src/main/proto/core_preferences.proto
#	app/src/main/res/layout/customize_app_drawer_fragment.xml
#	app/src/main/res/values-de/strings.xml
Copy link
Owner

@jkuester jkuester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks @JuanJakobo for this functionality! I had to tweak things a bit to get this into the latest codebase, but I think that made things even more streamlined from a code perspective (functionality should still be the same)!

@jkuester jkuester linked an issue Dec 26, 2023 that may be closed by this pull request
@jkuester jkuester changed the title Add #103 make hidden apps findable with search feat(#103): make hidden apps findable with search Dec 26, 2023
@jkuester jkuester merged commit 4b25d7e into jkuester:master Dec 26, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Browse hidden apps
3 participants