cosmetic changes, small bug fixes

jku-vds-lab · Jan 4, 2021 · 94a393f · 94a393f
1 parent 085bfb3
commit 94a393f
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 7 deletions.
diff --git a/index.html b/index.html
@@ -59,17 +59,17 @@ <h2>Apply Effects for Better or Worse</h2>
                     <div hidden=true><input type="checkbox" id="RedGrid" name="RedGrid" ><label for="RedGrid">Red Grid lines</label><br></div>
                     <div hidden=true><input type="checkbox" id="BrightBackground" name="BrightBackground"><label for="BrightBackground">Bright Background</label><br></div>
                     <div id = "ZeroBox" hidden=true class="effect-box">
-                        <div class="sub-effect"><input type="checkbox" id="Zero" name="Zero"><label for="Zero">Force Zero into Quantitative Ranges on Axis</label><br></div></div>
+                        <div class="sub-effect"><input type="checkbox" id="Zero" name="Zero"><label for="Zero">Force Zero into Quantitative Ranges on Axes</label><br></div></div>
                     <div id = 'ColorSeqNominalBox' hidden=true class="effect-box">
                         <div class="sub-effect"><input type="checkbox" id="ColorSeqNominal" name="ColorSeqNominal"><label for="ColorSeqNominal">Apply Sequential Color Scheme</label><br></div></div>
                     <div id = 'OverplottingTranspBox' hidden=true class="effect-box">
-                        <div id = "OverplottingTranspSubBox" class="sub-effect"><input type="checkbox" id="OverplottingTransp" name="OverplottingTransp"><label for="OverplottingTransp">Set low opacity of the marks 🤔</label><br></div>
+                        <div id = "OverplottingTranspSubBox" class="sub-effect"><input type="checkbox" id="OverplottingTransp" name="OverplottingTransp"><label for="OverplottingTransp">Set Low Opacity of the Marks</label><br></div>
 
-                        <div id = "SamplingBox" hidden=true class="sub-effect"><input type="checkbox" id="Sampling" name="Sampling"><label for="Sampling">Sample 25% of your data</label><br></div></div>
+                        <div id = "SamplingBox" hidden=true class="sub-effect"><input type="checkbox" id="Sampling" name="Sampling"><label for="Sampling">Sample 25% of the Data</label><br></div></div>
                     <div id = "WallpaperBox" hidden=true class="effect-box">
-                        <div class="sub-effect"><input type="checkbox" id="Wallpaper" name="Wallpaper" ><label for="Wallpaper">Add a subtle texture as a wallpaper</label><br></div></div>
+                        <div class="sub-effect"><input type="checkbox" id="Wallpaper" name="Wallpaper" ><label for="Wallpaper">Add Subtle Texture as a Wallpaper</label><br></div></div>
                     <div id = "RoundBarsBox" hidden=true class="effect-box">
-                        <div class="sub-effect"><input type="checkbox" id="RoundBars" name="RoundBars"><label for="RoundBars">Apply round corners to bars</label><br></div></div>
+                        <div class="sub-effect"><input type="checkbox" id="RoundBars" name="RoundBars"><label for="RoundBars">Apply Round Corners to Bars</label><br></div></div>
                 </div>
             </div>
             <div class="Container-low">

diff --git a/src/effects.ts b/src/effects.ts
@@ -252,7 +252,7 @@ export class Effector {
     }
 
     private Zero () {
-      const msg = "Without zero as a reference point it is much harder to compare values graphically. It usually exaggregates difference between values;";
+      const msg = "Without zero as a reference point it is much harder to compare values graphically. It usually exaggerates difference between values;";
       // if the effect was active initially an we are asked to activate it again
       // we return original user source regarding this effect, do nothing:
       if (this.effects["Zero"]["on"] == this.effects["Zero"]["initial_on"]) return;

diff --git a/src/index.ts b/src/index.ts
@@ -406,7 +406,7 @@ function updateFeedback(message : string, oldScore : number,  score : number, ma
   }
 }
 
-document.addEventListener('keypress', (event) => {
+$(document).on("keypress",(event) => {
   firstLaunch = false;
   quickStart();});
 
@@ -479,6 +479,7 @@ function setShowEffects() {
                             smoothTextChange("Institute of Computer Graphics, Johannes Kepler University Linz, Austria, 2020",".footer");
                           },4200);
                             $("#global_div").off();
+                            $(document).off();
                             firstLaunch = false;
                         }
                       )
@@ -519,4 +520,6 @@ function quickStart(){
   setTimeout(()=>{
     smoothTextChange("Institute of Computer Graphics, Johannes Kepler University Linz, Austria, 2020",".footer");
   },1500);
+  $("#global_div").off();
+  $(document).off();
 }