Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test hook for retrieving ConfigSourceSupplier values immediately #24

Merged
merged 2 commits into from
Sep 12, 2020

Conversation

bbaldino
Copy link
Member

See #23

@codecov
Copy link

codecov bot commented Sep 11, 2020

Codecov Report

Merging #24 into master will increase coverage by 1.45%.
The diff coverage is 50.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #24      +/-   ##
============================================
+ Coverage     75.78%   77.24%   +1.45%     
  Complexity       46       46              
============================================
  Files            18       17       -1     
  Lines           190      189       -1     
  Branches         14       13       -1     
============================================
+ Hits            144      146       +2     
+ Misses           40       36       -4     
- Partials          6        7       +1     
Impacted Files Coverage Δ Complexity Δ
.../jitsi/metaconfig/supplier/ConfigSourceSupplier.kt 88.00% <33.33%> (-7.46%) 7.00 <0.00> (ø)
.../kotlin/org/jitsi/metaconfig/MetaconfigSettings.kt 61.53% <100.00%> (+3.20%) 1.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30cdd3e...e279b22. Read the comment docs.

@bbaldino bbaldino merged commit 315a3ce into jitsi:master Sep 12, 2020
@bbaldino bbaldino deleted the retrieve_immediately branch September 12, 2020 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants