Added heart reaction feature #15291
Merged
Added heart reaction feature #15291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, thanks for your contribution! |
|
What is the origin of the sound files? |
They are from https://uppbeat.io/ made by Epic Stock Media |
|
Drop the last commit, it is not relevant to this feature. |
aaronkvanmeerten
previously approved these changes
Nov 12, 2024
|
jenkins test this please. |
damencho
requested changes
Nov 13, 2024
|
jenkins test this please. |
damencho
approved these changes
Nov 13, 2024
|
Cheers! Thank you for your contribution. |
|
Thanks for the contribution! Please use ~/resources/encode-sound.sh to encode the files next time (to keep the size smaller and formats consistent) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #15211
Added the heart reaction icon to the Reaction pane and also the necessary audio files for the reaction.