Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Video): Handle .play() errors. #15284

Merged
merged 1 commit into from
Nov 11, 2024
Merged

feat(Video): Handle .play() errors. #15284

merged 1 commit into from
Nov 11, 2024

Conversation

hristoterezov
Copy link
Member

  • Do not throw the error. This results in unhandled rejection promise.
  • Add proper logging so that we can figure out from which video element the error occured.

@hristoterezov
feat(Video): Handle .play() errors.
26d4788 
 - Do not throw the error. This results in unhandled rejection promise.
 - Add proper logging so that we can figure out from which video element the error occured.
@hristoterezov hristoterezov merged commit 86d1bd3 into master Nov 11, 2024
9 checks passed
@hristoterezov hristoterezov deleted the video-play-reject branch November 11, 2024 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damencho damencho damencho approved these changes

@saghul saghul saghul approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hristoterezov @saghul @damencho