fix(local-recording) handle repeated values

jitsi · Nov 14, 2024 · ee470f2 · ee470f2
1 parent def9555
commit ee470f2
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/react/features/base/participants/middleware.ts b/react/features/base/participants/middleware.ts
@@ -454,7 +454,7 @@ StateListenerRegistry.register(
                         features: { 'screen-sharing': true }
                     })),
                 'localRecording': (participant: IJitsiParticipant, value: string) =>
-                    _localRecordingUpdated(store, conference, participant.getId(), value),
+                    _localRecordingUpdated(store, conference, participant.getId(), Boolean(value)),
                 'raisedHand': (participant: IJitsiParticipant, value: string) =>
                     _raiseHandUpdated(store, conference, participant.getId(), value),
                 'region': (participant: IJitsiParticipant, value: string) =>
@@ -714,8 +714,13 @@ function _participantJoinedOrUpdated(store: IStore, next: Function, action: AnyA
  * @returns {void}
  */
 function _localRecordingUpdated({ dispatch, getState }: IStore, conference: IJitsiConference,
-        participantId: string, newValue: string) {
+        participantId: string, newValue: boolean) {
     const state = getState();
+    const participant = getParticipantById(state, participantId);
+
+    if (participant?.localRecording === newValue) {
+        return;
+    }
 
     dispatch(participantUpdated({
         conference,

diff --git a/react/features/base/participants/types.ts b/react/features/base/participants/types.ts
@@ -31,7 +31,7 @@ export interface IParticipant {
     loadableAvatarUrl?: string;
     loadableAvatarUrlUseCORS?: boolean;
     local?: boolean;
-    localRecording?: string;
+    localRecording?: boolean;
     name?: string;
     pinned?: boolean;
     presence?: string;