-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UPDATES: Steward Test Branch to Release #63
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Christian <[email protected]>
Starting to add the solution for keeping track of removed validators --------- Co-authored-by: Christian <[email protected]>
This PR adds the Steward CLI that can create and crank through the entire Steward state machine. It also introduces some fixes to the Steward program.
- [x] Separate authorities (blacklist, parameters, admin council: reset, pausing + passthrough?) - [x] Remove staker PDA in favor of State account - [x] Add ValidatorList address to Config so we can validate the list in instructions that don’t pass in the stake pool - [x] Test RemoveValidator for validators that don’t have score computed - [x] Adjust increase_validator_stake reserve_lamports to protect transient stake rent for other accounts - [x] Figure out a better system for persisting blacklist validator indices - [x] Add a check for Deactivate* state at the index marked for removal in epoch_maintenance --------- Co-authored-by: Evan Batsell <[email protected]>
Puts all events except for Scoring / instant unstake response types in a single file
- Added status flags for better tracking of the state machine - Fixed issue on new epoch not being able to reset state to idle --------- Co-authored-by: Christian Krueger <[email protected]>
To cover the edge case when some validators can be removed on the same epoch, we treat them differently. If there are any validators that are marked for instant removal - they have to be removed before anything else can happen. This could be further cleaned by running epoch maintenance over all validators. But for now, it should cover us. --------- Co-authored-by: Christian Krueger <[email protected]>
The new `crank_checks` function does all of the checks needed across each crank. Now with the new addition of looking for mismatched indices. --------- Co-authored-by: Christian Krueger <[email protected]> Co-authored-by: Evan Batsell <[email protected]>
Co-authored-by: Christian Krueger <[email protected]>
Co-authored-by: Christian Krueger <[email protected]>
Co-authored-by: Christian Krueger <[email protected]>
coachchucksol
commented
Jul 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
ebatsell
approved these changes
Jul 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The big boi, after lots of testing and audits, it's time to release the Steward.