PROGRAM TWEAKS #52
Merged
PROGRAM TWEAKS #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
coachchucksol
commented
Jun 26, 2024
coachchucksol
commented
- Separate authorities (blacklist, parameters, admin council: reset, pausing + passthrough?)
- Remove staker PDA in favor of State account
- Add ValidatorList address to Config so we can validate the list in instructions that don’t pass in the stake pool
- Test RemoveValidator for validators that don’t have score computed
- Adjust increase_validator_stake reserve_lamports to protect transient stake rent for other accounts
- Figure out a better system for persisting blacklist validator indices
- Add a check for Deactivate* state at the index marked for removal in epoch_maintenance
ebatsell
reviewed
Jun 26, 2024
ebatsell
reviewed
Jun 26, 2024
| } | ||
| } | ||
|
|
||
| // static_assertions::const_assert_eq!(StewardStateAccount::SIZE, 162584); |
There was a problem hiding this comment.
let's keep this - still want to uncomment this once State size is finalized. Here to ensure that the account size doesn't change in future PRs after it goes live
| @@ -44,9 +45,7 @@ pub struct ReallocState<'info> { | |||
| pub config: AccountLoader<'info, Config>, | |||
|
|
|||
| /// CHECK: TODO add validator_list address to config | |||
|
Before merge:
|
ebatsell
reviewed
Jun 28, 2024
ebatsell
approved these changes
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.