Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add historical_commission_threshold and fixes instant unstaking bug #42

Merged
merged 6 commits into from
Jun 4, 2024
Merged

Add historical_commission_threshold and fixes instant unstaking bug #42

merged 6 commits into from
Jun 4, 2024

Conversation

ebatsell
Copy link
Collaborator

@ebatsell ebatsell commented Jun 3, 2024

  • Adds historical_commission_threshold as described in the Steward README. Requires a compiler feature when building the main image to specify VALIDATOR_HISTORY_FIRST_RELIABLE_EPOCH for the given network this is running on.
  • Fixes a bug in which validators with stake that are not in the delegation set would not be checked for instant unstake status, which was wrong because we still need to be able to instant unstake these validators if they commission rug or go delinquent.
  • Re-enables testing of Steward tests in CI.

@ebatsell ebatsell requested review from buffalu and coachchucksol June 3, 2024 19:20
coachchucksol

This comment was marked as resolved.

Sign in to view

@coachchucksol coachchucksol dismissed their stale review June 3, 2024 21:21

This is implementing the historical_commission_threshold already in README

@coachchucksol coachchucksol self-requested a review June 3, 2024 21:21
coachchucksol
coachchucksol approved these changes Jun 3, 2024
View reviewed changes
Copy link
Contributor

@coachchucksol coachchucksol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good to me

@ebatsell ebatsell merged commit 3bc3ae7 into master Jun 4, 2024
6 checks passed
@ebatsell ebatsell deleted the evan/commission-history-instant-unstake branch June 4, 2024 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coachchucksol coachchucksol coachchucksol approved these changes

@buffalu buffalu Awaiting requested review from buffalu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ebatsell @coachchucksol