FEATURE: Adding metrics - num_get_vote_accounts_voting, num_live_validator_histories #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebatsell
reviewed
May 10, 2024
coachchucksol
changed the title
…into adding_metrics
ebatsell
reviewed
May 10, 2024
keepers/validator-keeper/src/lib.rs
Outdated
| let live_validator_histories_count = | ||
| get_multiple_accounts_batched(&all_history_vote_accounts, client) | ||
| .await | ||
| .expect("Cannot fetch validator history vote accounts") |
There was a problem hiding this comment.
? here instead of expect
ebatsell
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added two new metrics to the
emit_validator_history_metricsfunction:num_live_validator_histories: The number of validator history accounts that have "live" vote accounts with the owner of said vote account being the vote programnum_get_vote_accounts_voting: The number of vote accounts actually voting. More specifically, accounts that have voted in the current epoch retrieved fromget_vote_accounts_with_retry.