Math fixes for cluster history slot counting #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebatsell
force-pushed
the
evan/cluster-history-math-fixes
branch
4 times, most recently
from
d8eaa6a to
b24a3df
Compare
ebatsell
force-pushed
the
evan/cluster-history-math-fixes
branch
from
b24a3df to
93a7c0c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the logic around reading partial blocks was slightly off, especially for cases where there are no full blocks in between the start and end slot. Also, making sure we don't read slots past the current slot when updating current epoch.