Fix compute budget overflow on SlotHistory reading #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buffalu
reviewed
Mar 6, 2024
buffalu
reviewed
Mar 6, 2024
| pub fn confirmed_blocks_in_epoch( | ||
| start_slot: u64, | ||
| end_slot: u64, | ||
| slot_history: SlotHistory, |
There was a problem hiding this comment.
I had this as Box<SlotHistory> but clippy complained, and it somehow works without copying the var.
Can't be &SlotHistory because the function takes ownership at the into_boxed_slice line
buffalu
reviewed
Mar 6, 2024
| cluster_history_account.set_blocks(epoch - 1, num_blocks)?; | ||
| // recreates SlotHistory with same heap memory chunk | ||
| Box::new(SlotHistory { | ||
| bits: bitvec_inner.into(), |
There was a problem hiding this comment.
shouldn't this be for the new epoch? weird bitvec_inner generated by start_slot, end_slot here from previous epoch then we use it below fo the current epoch
There was a problem hiding this comment.
SlotHistory contains last 1,048,576 slots so it will always contain all slots from last epoch and this epoch. Recreating it here to avoid copying + ownership issues. Can add a comment about how it contains both epochs of slots
buffalu
reviewed
Mar 6, 2024
programs/validator-history/src/instructions/copy_cluster_info.rs
Outdated
Show resolved
Hide resolved
buffalu
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.