PR feedback

jito-foundation · Jun 19, 2024 · 3110775 · 3110775
1 parent 6ebbd6d
commit 3110775
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/programs/steward/src/constants.rs b/programs/steward/src/constants.rs
@@ -12,6 +12,6 @@ pub const NUM_EPOCHS_BETWEEN_SCORING_MAX: u64 = 100;
 // Cannot score validators in under 100 slots, to submit 1 instruction per validator
 pub const COMPUTE_SCORE_SLOT_RANGE_MIN: u64 = 100;
 #[cfg(feature = "mainnet-beta")]
-pub const VALIDATOR_HISTORY_FIRST_RELIABLE_EPOCH: usize = 520;
+pub const VALIDATOR_HISTORY_FIRST_RELIABLE_EPOCH: u64 = 520;
 #[cfg(not(feature = "mainnet-beta"))]
-pub const VALIDATOR_HISTORY_FIRST_RELIABLE_EPOCH: usize = 0;
+pub const VALIDATOR_HISTORY_FIRST_RELIABLE_EPOCH: u64 = 0;
diff --git a/programs/steward/src/instructions/compute_instant_unstake.rs b/programs/steward/src/instructions/compute_instant_unstake.rs
@@ -18,7 +18,7 @@ pub struct ComputeInstantUnstake<'info> {
 
     pub validator_history: AccountLoader<'info, ValidatorHistory>,
 
-    /// CHECK: TODO
+    /// CHECK: TODO add validator list to config
     #[account(owner = spl_stake_pool::id())]
     pub validator_list: AccountInfo<'info>,
 

diff --git a/programs/steward/src/state/parameters.rs b/programs/steward/src/state/parameters.rs
@@ -327,11 +327,11 @@ impl Parameters {
     /// Validate reasonable bounds on parameters
     pub fn validate(&self, current_epoch: u64, slots_per_epoch: u64) -> Result<()> {
         // Cannot evaluate epochs before VALIDATOR_HISTORY_FIRST_RELIABLE_EPOCH or beyond the CircBuf length
-        let window_max = (current_epoch as usize)
+        let window_max = current_epoch
             .checked_sub(VALIDATOR_HISTORY_FIRST_RELIABLE_EPOCH)
             .ok_or(StewardError::ArithmeticError)?
             .min(validator_history::ValidatorHistory::MAX_ITEMS - 1);
-        let window_max = cast_epoch(window_max as u64)?;
+        let window_max = cast_epoch(window_max)?;
 
         if self.mev_commission_range > window_max {
             return Err(StewardError::InvalidParameterValue.into());