Emit VRT supply in cranker #174
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebatsell
commented
Nov 20, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #174 +/- ##
=======================================
Coverage 80.70% 80.70%
=======================================
Files 91 91
Lines 9944 9944
=======================================
Hits 8025 8025
Misses 1919 1919 ☔ View full report in Codecov by Sentry. |
buffalu
reviewed
Nov 20, 2024
crankers/src/metrics.rs
Outdated
| "restaking-vault-supply", | ||
| ("slot", slot as i64, i64), | ||
| ("slot_index", slot_index as i64, i64), | ||
| ("vault", address.to_string(), String), |
There was a problem hiding this comment.
"vault" => address.to_string() so vault is a tag
There was a problem hiding this comment.
what would the full tuple look like then?
There was a problem hiding this comment.
i think you can do:
datapoint_info!(
"restaking-vault-supply",
"vault" => address.to_string(),
("slot", slot as i64, i64),
...);
There was a problem hiding this comment.
can do the same with vrt_mint too
ebatsell
commented
Dec 30, 2024
coachchucksol
approved these changes
Dec 31, 2024
crankers/src/metrics.rs
Outdated
| ("slot", slot as i64, i64), | ||
| ("slot_index", slot_index as i64, i64), | ||
| ("vault", address.to_string(), String), | ||
| ("vrt_mint", vault.vrt_mint.to_string(), String), |
There was a problem hiding this comment.
Do we also want ST supply?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.