Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cranker ready for deployment #164

Merged
merged 5 commits into from
Nov 1, 2024
Merged

Cranker ready for deployment #164

merged 5 commits into from
Nov 1, 2024

Conversation

ebatsell
Copy link
Contributor

@ebatsell ebatsell commented Oct 30, 2024

Tested docker and it works.

@ebatsell ebatsell marked this pull request as ready for review October 30, 2024 23:09
Copy link

codecov bot commented Oct 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.22%. Comparing base (6dab154) to head (de07b54).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #164   +/-   ##
=======================================
  Coverage   78.22%   78.22%           
=======================================
  Files          89       89           
  Lines        9232     9232           
=======================================
  Hits         7222     7222           
  Misses       2010     2010           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aoikurokawa
Copy link
Contributor

aoikurokawa commented Oct 31, 2024

I made a mistake of the name of parameter. Could you change it? Arigato!
keypair -> keypair-path
https://github.com/jito-foundation/restaking/pull/164/files#diff-37d7fb4b976f966ae6d96e5f9ef481562bca70893bd993c121f508396c06fb48R24-R30

RUN cargo build --release --bin jito-vault-crank


RUN cargo build --release --bin jito-vault-crank
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extra copy paste

@coachchucksol coachchucksol self-requested a review October 31, 2024 18:08
Copy link
Contributor

@coachchucksol coachchucksol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@ebatsell ebatsell merged commit 4c37d76 into master Nov 1, 2024
6 checks passed
@ebatsell ebatsell deleted the eb/cranker-deploy branch November 1, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants