VAULT: Require inital supply when creating vault #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Take out slash. I've opted for removal over no-op since we'll learn things as the program goes live. Slash should be designed around that new information.
Rotates the operator index we start on based on epoch % num_operators. Internally just tracks a counter from 0..num_operators and increments that, converting to the expected index number in check_and_update_index(). --------- Co-authored-by: Coach Chuck <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #150 +/- ##
==========================================
+ Coverage 79.39% 79.97% +0.57%
==========================================
Files 89 90 +1
Lines 9338 9688 +350
==========================================
+ Hits 7414 7748 +334
- Misses 1924 1940 +16 ☔ View full report in Codecov by Sentry. |
buffalu
approved these changes
Nov 26, 2024
buffalu
requested changes
Dec 16, 2024
buffalu
reviewed
Dec 16, 2024
buffalu
reviewed
Dec 16, 2024
coachchucksol
commented
Dec 20, 2024
coachchucksol
commented
Dec 20, 2024
buffalu
reviewed
Dec 22, 2024
buffalu
reviewed
Dec 22, 2024
buffalu
reviewed
Dec 22, 2024
buffalu
approved these changes
Dec 23, 2024
coachchucksol
added a commit
that referenced
this pull request
Dec 23, 2024
We require an intial deposit of some amount of the supported token to create the vault - the resulting VRT is "burned" meaning the vault will always have some min supply --------- Co-authored-by: Evan B <[email protected]> Co-authored-by: buffalu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We require an intial deposit of some amount of the supported token to create the vault - the resulting VRT is "burned" meaning the vault will always have some min supply