Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport #611 #631

Merged
merged 1 commit into from
Jul 21, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 20 additions & 6 deletions core/src/banking_stage/unprocessed_transaction_storage.rs
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ use {
},
itertools::Itertools,
min_max_heap::MinMaxHeap,
solana_bundle::BundleExecutionError,
solana_bundle::{bundle_execution::LoadAndExecuteBundleError, BundleExecutionError},
solana_measure::{measure, measure_us},
solana_runtime::bank::Bank,
solana_sdk::{
Expand Down Expand Up @@ -1314,18 +1314,32 @@ impl BundleStorage {
rebuffered_bundles.push(deserialized_bundle);
is_slot_over = true;
}
Err(BundleExecutionError::ExceedsCostModel) => {
// cost model buffered bundles contain most recent bundles at the front of the queue
debug!(
"bundle={} exceeds cost model, rebuffering",
sanitized_bundle.bundle_id
);
self.push_back_cost_model_buffered_bundles(vec![deserialized_bundle]);
}
Err(BundleExecutionError::TransactionFailure(
LoadAndExecuteBundleError::ProcessingTimeExceeded(_),
)) => {
// these are treated the same as exceeds cost model and are rebuferred to be completed
// at the beginning of the next slot
debug!(
"bundle={} processing time exceeded, rebuffering",
sanitized_bundle.bundle_id
);
self.push_back_cost_model_buffered_bundles(vec![deserialized_bundle]);
}
Err(BundleExecutionError::TransactionFailure(e)) => {
debug!(
"bundle={} execution error: {:?}",
sanitized_bundle.bundle_id, e
);
// do nothing
}
Err(BundleExecutionError::ExceedsCostModel) => {
// cost model buffered bundles contain most recent bundles at the front of the queue
debug!("bundle={} exceeds cost model", sanitized_bundle.bundle_id);
self.push_back_cost_model_buffered_bundles(vec![deserialized_bundle]);
}
Err(BundleExecutionError::TipError(e)) => {
debug!("bundle={} tip error: {}", sanitized_bundle.bundle_id, e);
// Tip errors are _typically_ due to misconfiguration (except for poh record error, bank processing error, exceeds cost model)
Expand Down
2 changes: 1 addition & 1 deletion core/src/bundle_stage.rs
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ mod bundle_reserved_space_manager;
pub(crate) mod bundle_stage_leader_metrics;
mod committer;

const MAX_BUNDLE_RETRY_DURATION: Duration = Duration::from_millis(10);
const MAX_BUNDLE_RETRY_DURATION: Duration = Duration::from_millis(40);
const SLOT_BOUNDARY_CHECK_PERIOD: Duration = Duration::from_millis(10);

// Stats emitted periodically
Expand Down
Loading