Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JIT-1706] Propagate heartbeat configs to relayer_config when updated thru CLI #492

Closed
wants to merge 4 commits into from
Closed

[JIT-1706] Propagate heartbeat configs to relayer_config when updated thru CLI #492

wants to merge 4 commits into from

Conversation

esemeniuc
Copy link
Contributor

Problem

The code to change the heartbeat interval and max failed heart beats through relayer_config on CLI is not propagated to FetchStageManager.

Summary of Changes

  • Wire up relayer_config
  • Restart loop when config updated
  • Add better error handling

Fixes #

@esemeniuc esemeniuc marked this pull request as ready for review December 1, 2023 15:53
@esemeniuc esemeniuc force-pushed the eric/fetch_stage_config branch from cb94e92 to 5714021 Compare December 1, 2023 16:01
@esemeniuc esemeniuc mentioned this pull request Dec 4, 2023
Merged
segfaultdoc
segfaultdoc reviewed Dec 4, 2023
View reviewed changes
core/src/proxy/fetch_stage_manager.rs
packet_tx: &Sender<PacketBatch>,
exit: &Arc<AtomicBool>,
) -> ProxyResult<()> {
let my_fallback_contact_info = cluster_info.my_contact_info();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add a comment on what this is and why we don't care if cluster_info gets changed via the admin rpc?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added a comment on the contact info. not sure what you would like to include wrt not caring if cluster_info gets changed

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So let's say validator starts up advertising relayer as it's TPU. Now let's say the following happens:

  1. Relayer crashes and misses heartbeat
  2. Validator falls back to original tpu
  3. Validator changes tpu socket via admin rpc
  4. Relayer reconnects
  5. Fails heartbeat
  6. Validator falls back to the original socket even though they had changed it in step 3

segfaultdoc
segfaultdoc reviewed Dec 4, 2023
View reviewed changes
core/src/proxy/fetch_stage_manager.rs
}
recv(relayer_config_tick) -> _ => {
if local_relayer_config != global_relayer_config.lock().unwrap().clone() {
return Err(ProxyError::RelayerConfigChanged);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doesn't seem like this should be an error? wdyt we just update the relevant vars if this changes

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we use the Err to signal the loop to reconnect. the return type is (). wdyt makes more sense?

@github-actions github-actions bot added the stale label Dec 25, 2023
@github-actions github-actions bot closed this Jan 1, 2024
@buffalu
jito patch
99f01af 
only reroute if relayer connected (#123)
feat: add client tls config (#121)
remove extra val (#129)
fix clippy (#130)
copy all binaries to docker-output (#131)
Ledger tool halts at slot passed to create-snapshot (#118)
update program submodule (#133)
quick fix for tips and clearing old bundles (#135)
update submodule to new program (#136)
Improve stake-meta-generator usability (#134)
pinning submodule head (#140)
Use BundleAccountLocker when handling tip txs (#147)
Add metrics for relayer + block engine proxy (#149)
Build claim-mev in docker (#141)
Rework bundle receiving and add metrics (#152) (#154)
update submodule + dev files (#158)
Deterministically find tip amounts, add meta to stake info, and cleanup pubkey/strings in MEV tips (#159)
update jito-programs submodule (#160)
Separate MEV tip related workflow (#161)
Add block builder fee protos (#162)
fix jito programs (#163)
update submodule so autosnapshot exits out of ledger tool early (#164)
Pipe through block builder fee (#167)
pull in new snapshot code (#171)
block builder bug (#172)

Pull in new slack autosnapshot submodule (#174)

sort stake meta json and use int math (#176)

add accountsdb conn submod (#169)

Update tip distribution parameters (#177)

new submodules (#180)

Add buildkite link for jito CI (#183)

Fixed broken links to repositories (#184)

Changed from ssh to https transfer for clone

Seg/update submods (#187)

fix tests (#190)

rm geyser submod (#192)

rm dangling geyser references (#193)

fix syntax err (#195)

use deterministic req ids in batch calls (#199)

update jito-programs

revert cargo

update Cargo lock

update with path fix

fix cargo

update autosnapshot with block lookback (#201)

[JIT-460] When claiming mev tips, skip accounts that won't have min rent exempt amount after claiming (#203)

Add logging for sol balance desired (#205)

* add logging

* add logging

* update msg

* tweak vars

update submodule (#204)

use efficient data structures when calling batch_simulate_bundles (#206)

[JIT-504] Add low balance check in uploading merkle roots (#209)

add config to simulate on top of working bank (#211)

rm frozen bank check

simulate_bundle rpc bugfixes (#214)

rm frozen bank check in simulate_bundle rpc method

[JIT-519] Store ClaimStatus address in merkle-root-json (#210)

* add files

* switch to include bump

update submodule (#217)

add amount filter (#218)

update autosnapshot (#222)

Print TX error in Bundles (#223)

add new args to support single relayer and block-engine endpoints (#224)

point to new jito-programs submod and invoke updated init tda instruction (#228)

fix clippy errors (#230)

fix validator start scripts (#232)

Point README to gitbook (#237)

use packaged cargo bin to build (#239)

Add validator identity pubkey to StakeMeta (#226)

The vote account associated with a validator is not a permanent link, so log the validator identity as well.

bugfix: conditionally compile with debug flags (#240)

Seg/tip distributor master (#242)

* validate tree nodes

* fix unit tests

* pr feedback

* bump jito-programs submod

Simplify bootstrapping (#241)

* startup without precompile

* update spacing

* use release mode

* spacing

fix validation

rm validation skip

Account for block builder fee when generating excess tip balance (#247)

Improve docker caching

delay constructing claim mev txs (#253)

fix stake meta tests from bb fee (#254)

fix tests

Buffer bundles that exceed cost model (#225)

* buffer bundles that exceed cost model

clear qos failed bundles buffer if not leader soon (#260)

update Cargo.lock to correct solana versions in jito-programs submodule (#265)

fix simulate_bundle client and better error handling (#267)

update submod (#272)

Preallocate Bundle Cost (#238)

fix Dockerfile (#278)

Fix Tests (#279)

Fix Tests (#281)

* fix tests

update jito-programs submod (#282)

add reclaim rent workflow (#283)

update jito-programs submod

fix clippy errs

rm wrong assertion and swap out file write fn call (#292)

Remove security.md (#293)

demote frequent relayer_stage-stream_error to warn (#275)

account for case where TDA exists but not allocated (#295)

implement better retries for tip-distributor workflows (#297)

limit number of concurrent rpc calls (#298)

Discard Empty Packet Batches (#299)

Identity Hotswap (#290)

small fixes (#305)

Set backend config from admin rpc (#304)

Admin Shred Receiver Change (#306)

Seg/rm bundle UUID (#309)

Fix github workflow to recursively clone (#327)

Add recursive checkout for downstream-project-spl.yaml (#341)

Use cluster info functions for tpu (#345)

Use git rev-parse for git sha

Remove blacklisted tx from message_hash_to_transaction (#374)

Updates bootstrap and start scripts needed for local dev. (#384)

Remove Deprecated Cli Args (#387)

Master Rebase

improve simulate_bundle errors and response (#404)

derive Clone on accountoverrides (#416)

Add upsert to AccountOverrides (#419)

update jito-programs (#430)

[JIT-1661] Faster Autosnapshot (#436)

Reverts simulate_transaction result calls to upstream (#446)

Don't unlock accounts in TransactionBatches used during simulation (#449)

first pass at wiring up jito-plugin (#428)

[JIT-1713] Fix bundle's blockspace preallocation (#489)

[JIT-1708] Fix TOC TOU condition for relayer and block engine config (#491)

[JIT-1710] - Optimize Bundle Consumer Checks (#490)

Add Blockhash Metrics to Bundle Committer (#500)

add priority fee ix to mev-claim (#520)

Update Autosnapshot (#548)

Run MEV claims + reclaiming rent-exempt amounts in parallel. (#582)

Update CI (#584)
- Add recursive submodule checkouts.
- Re-add solana-secondary step
@esemeniuc esemeniuc reopened this Feb 1, 2024
@esemeniuc esemeniuc force-pushed the eric/fetch_stage_config branch from 755b126 to ebaf95b Compare February 1, 2024 04:25
@esemeniuc esemeniuc removed the stale label Feb 1, 2024
@esemeniuc
Revert "revert"
432784b 
This reverts commit f2f2286.
@segfaultdoc segfaultdoc self-requested a review February 5, 2024 19:09
@buffalu buffalu force-pushed the master branch 2 times, most recently from 7e02a2a to 3be84f5 Compare February 27, 2024 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jedleggett jedleggett Awaiting requested review from jedleggett

@buffalu buffalu Awaiting requested review from buffalu

@segfaultdoc segfaultdoc Awaiting requested review from segfaultdoc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@esemeniuc @segfaultdoc @buffalu