Bug fix for have_failed with RSpec 3.0.0
#43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of a recent [commit](https://github.com/rspec/rspec-expectations/blame/79582c2c160ac7b3a58d3d128012b022c63d6174/lib/rspec/matchers/built_in/raise_error.rb#L38) to rspec-expectations, Rspec::Matchers::BuiltIn::RaiseError strictly requires a Proc rather than something that quacks like one.
benizi
added a commit
to forever-inc/netsweet
that referenced
this pull request
Jun 9, 2014
|
Hey ronen — I'm going to take a look at this branch today. Do you think it's ready to merge into rspec-given's new repo? https://github.com/rspec-given/rspec-given |
|
hey justin -- glad to see you've taken on this gem!
hmm.... no idea... i haven't thought about this issue or looked at any of the repos since i submitted the PR... |
|
No worries. Fortunately there were tests broken by your issue and this patch fixes several of them. I'm digging into it now and I think I understand the RSpec API change that caused the issue. I've already merged your patch into my PR and you'll get the credit :D |
|
Cool, glad you're on top of it. |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With Mr. Weirich sadly no longer with us, I don't know who if anyone wil be maintaing this, but I figure I may as well at least post the issue/PR in case anybody else comes across the same issue.
With the release of RSpec 3.0.0, the
have_failedmechanism no longer works. Attempting:Results in an error like:
This PR should fix that.
(The specific RSpec change that caused this to break was rspec/rspec-expections@79582c2, which cleaned up the delineation between blocks and values for expect { } vs expect() as per rspec/rspec-expectations#526 ; unfortunately rspec-given was relying on the previous looseness to be able to use a value that quacked like a Proc.)