Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VSF 1.11 compat #11

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from
Open

Conversation

didkan
Copy link

@didkan didkan commented Mar 12, 2021

These are the changes I had to make to get the module to build with VSF 1.11.4.

  • Remove semi colon to fix ESlint warnings
  • Remove the use of SideRequest() (Does not exist in 1.11 any more?)
  • Fix missing slash when constructing api URL
  • Upgrade module to use the new 1.11 module api pattern

@benoitemile
Copy link

hi @jimmy-lion any updates on this ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants