Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

draft: Apply rector php82 #1174

Closed
wants to merge 7 commits into from
Closed

draft: Apply rector php82 #1174

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
814b079
deps: upgrade phpstan
Rubc Mar 18, 2024
2cca362
fix phpstan errors
Rubc Mar 18, 2024
a31bd16
deps: add rector as dev dependency
Rubc Mar 18, 2024
1022911
Run rector with php82 setlist
Rubc Mar 18, 2024
60e89e9
fix: remove return types of rrd storage
Rubc Mar 18, 2024
0d60789
fix return type of Slave/Device
Rubc Mar 18, 2024
744e42b
fix queue test
Rubc Mar 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,8 +63,11 @@
"mi-schi/phpmd-extension": "^4.2",
"phpmd/phpmd": "^2.6",
"phpspec/prophecy": "^1.19",
"phpstan/phpstan": "^0.12",
"phpstan/extension-installer": "^1.3",
"phpstan/phpstan": "^1.9",
"phpstan/phpstan-doctrine": "^1.3",
"phpunit/phpunit": "^9.6",
"rector/rector": "^1.0",
"squizlabs/php_codesniffer": "^3.3",
"symfony/browser-kit": "^5.0",
"symfony/css-selector": "^5.0",
Expand Down Expand Up @@ -94,7 +97,8 @@
"sort-packages": true,
"process-timeout": 0,
"allow-plugins": {
"symfony/flex": true
"symfony/flex": true,
"phpstan/extension-installer": true
}
},
"conflict": {
Expand Down
204 changes: 187 additions & 17 deletions composer.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion fixtures/ORM/AlertDestinationFixtures.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@

class AlertDestinationFixtures extends Fixture
{
public function load(ObjectManager $manager)
public function load(ObjectManager $manager): void
{
$alertDestination = new AlertDestination();
$alertDestination->setName('syslog');
Expand Down
2 changes: 1 addition & 1 deletion fixtures/ORM/AlertFixtures.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

class AlertFixtures extends Fixture implements DependentFixtureInterface
{
public function load(ObjectManager $manager)
public function load(ObjectManager $manager): void
{
$alert = new Alert();
$alert->setActive(1);
Expand Down
2 changes: 1 addition & 1 deletion fixtures/ORM/AlertRuleFixtures.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

class AlertRuleFixtures extends Fixture implements DependentFixtureInterface
{
public function load(ObjectManager $manager)
public function load(ObjectManager $manager): void
{
$alertrule = new AlertRule();
$alertrule->setName('Alertrule 1');
Expand Down
2 changes: 1 addition & 1 deletion fixtures/ORM/DeviceFixtures.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

class DeviceFixtures extends Fixture implements DependentFixtureInterface
{
public function load(ObjectManager $manager)
public function load(ObjectManager $manager): void
{
$device = new Device();
$device->setName('Device 1');
Expand Down
2 changes: 1 addition & 1 deletion fixtures/ORM/DomainFixtures.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

class DomainFixtures extends Fixture implements DependentFixtureInterface
{
public function load(ObjectManager $manager)
public function load(ObjectManager $manager): void
{
$domain = new Domain();
$domain->setId(1);
Expand Down
2 changes: 1 addition & 1 deletion fixtures/ORM/ProbeArchiveFixtures.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

class ProbeArchiveFixtures extends Fixture implements DependentFixtureInterface
{
public function load(ObjectManager $manager)
public function load(ObjectManager $manager): void
{
$probeArchive = new ProbeArchive();
$probeArchive->setFunction('AVERAGE');
Expand Down
2 changes: 1 addition & 1 deletion fixtures/ORM/ProbeFixtures.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@

class ProbeFixtures extends Fixture
{
public function load(ObjectManager $manager)
public function load(ObjectManager $manager): void
{
$probe = new Probe();
$probe->setName('Ping');
Expand Down
2 changes: 1 addition & 1 deletion fixtures/ORM/SlaveFixtures.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

class SlaveFixtures extends Fixture implements DependentFixtureInterface
{
public function load(ObjectManager $manager)
public function load(ObjectManager $manager): void
{
$slave = new Slave();
$slave->setId('slave1');
Expand Down
2 changes: 1 addition & 1 deletion fixtures/ORM/SlaveGroupFixtures.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@

class SlaveGroupFixtures extends Fixture
{
public function load(ObjectManager $manager)
public function load(ObjectManager $manager): void
{
$slavegroup = new SlaveGroup();
$slavegroup->setName('Slavegroup 1');
Expand Down
2 changes: 1 addition & 1 deletion fixtures/ORM/StorageNodeFixtures.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@

class StorageNodeFixtures extends Fixture
{
public function load(ObjectManager $manager)
public function load(ObjectManager $manager): void
{
$node = new StorageNode();
$node->setIp('127.0.0.1');
Expand Down
2 changes: 1 addition & 1 deletion fixtures/ORM/UserFixtures.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ public function __construct(PasswordHasherFactoryInterface $passwordHasherFactor
$this->passwordHasherFactory = $passwordHasherFactory;
}

public function load(ObjectManager $manager)
public function load(ObjectManager $manager): void
{
// Create our user and set details
$user = new User();
Expand Down
4 changes: 2 additions & 2 deletions phpstan.neon
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
parameters:
inferPrivatePropertyTypeFromConstructor: true
excludes_analyse:
- %rootDir%/../../../src/Migrations/*
excludePaths:
- %rootDir%/../../../src/Migrations/*
Loading
Loading