Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Peer Review #13

Open
wants to merge 79 commits into
base: review
Choose a base branch
from
Open

Peer Review #13

wants to merge 79 commits into from

Commits on Jan 15, 2019

  1. fixed README

    vagrant committed Jan 15, 2019
    Configuration menu
    Copy the full SHA
    2a976f6 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #1 from jillianKhoo/readme 

    fixed README
    @jillianKhoo
    jillianKhoo authored Jan 15, 2019
    Configuration menu
    Copy the full SHA
    705b342 View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2019

  1. added backend key value store stubs and got it to compile

    vagrant committed Jan 17, 2019
    Configuration menu
    Copy the full SHA
    f26ed86 View commit details
    Browse the repository at this point in the history

  2. added a map to backendStore

    vagrant committed Jan 17, 2019
    Configuration menu
    Copy the full SHA
    29c24a2 View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2019

  1. removed generated files

    vagrant committed Jan 18, 2019
    Configuration menu
    Copy the full SHA
    caccaed View commit details
    Browse the repository at this point in the history

  2. added a gitignore

    vagrant committed Jan 18, 2019
    Configuration menu
    Copy the full SHA
    ed2a14f View commit details
    Browse the repository at this point in the history

  3. fixed a line of the gitignore, made structural changes for the KeyVal… 

    …ueStoreServiceImpl class
    vagrant committed Jan 18, 2019
    Configuration menu
    Copy the full SHA
    9c126ee View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2019

  1. naming fixes

    vagrant committed Jan 19, 2019
    Configuration menu
    Copy the full SHA
    ab509da View commit details
    Browse the repository at this point in the history

Commits on Jan 20, 2019

  1. comment fixes

    vagrant committed Jan 20, 2019
    Configuration menu
    Copy the full SHA
    df67474 View commit details
    Browse the repository at this point in the history

Commits on Jan 21, 2019

  1. Merge pull request #2 from jillianKhoo/initial-stubs 

    Initial stubs for backend key-value store
    @jillianKhoo
    jillianKhoo authored Jan 21, 2019
    Configuration menu
    Copy the full SHA
    ad67fdf View commit details
    Browse the repository at this point in the history

Commits on Jan 22, 2019

  1. added proto file for service layer

    vagrant committed Jan 22, 2019
    Configuration menu
    Copy the full SHA
    b0d3d3a View commit details
    Browse the repository at this point in the history

  2. added empty file structure

    vagrant committed Jan 22, 2019
    Configuration menu
    Copy the full SHA
    b8f3f98 View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2019

  1. stubs for service layer

    vagrant committed Jan 23, 2019
    Configuration menu
    Copy the full SHA
    4696641 View commit details
    Browse the repository at this point in the history

  2. assorted PR fixes

    vagrant committed Jan 23, 2019
    Configuration menu
    Copy the full SHA
    71d0205 View commit details
    Browse the repository at this point in the history

  3. service header file fixes

    vagrant committed Jan 23, 2019
    Configuration menu
    Copy the full SHA
    bd9d1a3 View commit details
    Browse the repository at this point in the history

  4. Merge pull request #3 from jillianKhoo/service-stubs 

    Service layer stubs
    @jillianKhoo
    jillianKhoo authored Jan 23, 2019
    Configuration menu
    Copy the full SHA
    31ea4b8 View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2019

  1. put code and a test

    vagrant committed Jan 24, 2019
    Configuration menu
    Copy the full SHA
    ba9a677 View commit details
    Browse the repository at this point in the history

  2. mini PR fixes

    vagrant committed Jan 24, 2019
    Configuration menu
    Copy the full SHA
    ef7a259 View commit details
    Browse the repository at this point in the history

  3. fixed gitignore

    vagrant committed Jan 24, 2019
    Configuration menu
    Copy the full SHA
    c609200 View commit details
    Browse the repository at this point in the history

  4. sample commit

    vagrant committed Jan 24, 2019
    Configuration menu
    Copy the full SHA
    55b931b View commit details
    Browse the repository at this point in the history

  5. added locks to put implementation

    vagrant committed Jan 24, 2019
    Configuration menu
    Copy the full SHA
    ee0c29f View commit details
    Browse the repository at this point in the history

  6. pr fix

    vagrant committed Jan 24, 2019
    Configuration menu
    Copy the full SHA
    f31815c View commit details
    Browse the repository at this point in the history

  7. one last catch:

    vagrant committed Jan 24, 2019
    Configuration menu
    Copy the full SHA
    56a6469 View commit details
    Browse the repository at this point in the history

  8. refactored to have data structure behind the service

    vagrant committed Jan 24, 2019
    Configuration menu
    Copy the full SHA
    fff2ddf View commit details
    Browse the repository at this point in the history

  9. added ServiceLayer class

    vagrant committed Jan 24, 2019
    Configuration menu
    Copy the full SHA
    cba612c View commit details
    Browse the repository at this point in the history

  10. pr fixes

    vagrant committed Jan 24, 2019
    Configuration menu
    Copy the full SHA
    23c8815 View commit details
    Browse the repository at this point in the history

  11. PR fixes

    vagrant committed Jan 24, 2019
    Configuration menu
    Copy the full SHA
    ddd105f View commit details
    Browse the repository at this point in the history

  12. missed something

    vagrant committed Jan 24, 2019
    Configuration menu
    Copy the full SHA
    0d82308 View commit details
    Browse the repository at this point in the history

  13. Merge pull request #5 from jillianKhoo/service-layer-data-structure 

    added ServiceLayer class
    @jillianKhoo
    jillianKhoo authored Jan 24, 2019
    Configuration menu
    Copy the full SHA
    43755ec View commit details
    Browse the repository at this point in the history

  14. Merge branch 'master' into backend-store-put

    @jillianKhoo
    jillianKhoo authored Jan 24, 2019
    Configuration menu
    Copy the full SHA
    a181e77 View commit details
    Browse the repository at this point in the history

  15. added TODO to test

    vagrant committed Jan 24, 2019
    Configuration menu
    Copy the full SHA
    2961008 View commit details
    Browse the repository at this point in the history

  16. Merge branch 'backend-store-put' of https://github.com/jillianKhoo/49… 

    …9-jkhoo into backend-store-put
    vagrant committed Jan 24, 2019
    Configuration menu
    Copy the full SHA
    280b9dd View commit details
    Browse the repository at this point in the history

  17. Merge pull request #4 from jillianKhoo/backend-store-put 

    Code for put and a basic test
    @jillianKhoo
    jillianKhoo authored Jan 24, 2019
    Configuration menu
    Copy the full SHA
    6f62ded View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2019

  1. get functionality and tests

    vagrant committed Jan 25, 2019
    Configuration menu
    Copy the full SHA
    1ebd1bd View commit details
    Browse the repository at this point in the history

  2. things noticed in reading diff

    vagrant committed Jan 25, 2019
    Configuration menu
    Copy the full SHA
    5aab1cc View commit details
    Browse the repository at this point in the history

  3. added delete functionality and tests

    vagrant committed Jan 25, 2019
    Configuration menu
    Copy the full SHA
    959fa13 View commit details
    Browse the repository at this point in the history

Commits on Jan 28, 2019

  1. PR fixes but not totally fixed

    vagrant committed Jan 28, 2019
    Configuration menu
    Copy the full SHA
    18e180b View commit details
    Browse the repository at this point in the history

Commits on Jan 29, 2019

  1. fixed everything

    vagrant committed Jan 29, 2019
    Configuration menu
    Copy the full SHA
    b994c5e View commit details
    Browse the repository at this point in the history

  2. PR fixes

    vagrant committed Jan 29, 2019
    Configuration menu
    Copy the full SHA
    6fa29e7 View commit details
    Browse the repository at this point in the history

  3. Merge pull request #6 from jillianKhoo/backend-store-get 

    get and delete functionality for backend store
    @jillianKhoo
    jillianKhoo authored Jan 29, 2019
    Configuration menu
    Copy the full SHA
    b5b522b View commit details
    Browse the repository at this point in the history

Commits on Jan 30, 2019

  1. implementation of register user

    vagrant committed Jan 30, 2019
    Configuration menu
    Copy the full SHA
    ce2b7a2 View commit details
    Browse the repository at this point in the history

  2. caught a couple things

    vagrant committed Jan 30, 2019
    Configuration menu
    Copy the full SHA
    b9e09ce View commit details
    Browse the repository at this point in the history

Commits on Jan 31, 2019

  1. I forgot to actually call the function

    vagrant committed Jan 31, 2019
    Configuration menu
    Copy the full SHA
    01b020c View commit details
    Browse the repository at this point in the history

  2. refactoring service layer and key value interaction

    vagrant committed Jan 31, 2019
    Configuration menu
    Copy the full SHA
    98cd8af View commit details
    Browse the repository at this point in the history

  3. added follow functionality

    vagrant committed Jan 31, 2019
    Configuration menu
    Copy the full SHA
    cddd70e View commit details
    Browse the repository at this point in the history

Commits on Feb 2, 2019

  1. PR fixes

    vagrant committed Feb 2, 2019
    Configuration menu
    Copy the full SHA
    94d74cb View commit details
    Browse the repository at this point in the history

  2. fixed get method in key value client

    vagrant committed Feb 2, 2019
    Configuration menu
    Copy the full SHA
    97f8d63 View commit details
    Browse the repository at this point in the history

Commits on Feb 3, 2019

  1. PR fixes

    vagrant committed Feb 3, 2019
    Configuration menu
    Copy the full SHA
    c69e322 View commit details
    Browse the repository at this point in the history

  2. removing old message

    vagrant committed Feb 3, 2019
    Configuration menu
    Copy the full SHA
    3df87b5 View commit details
    Browse the repository at this point in the history

  3. Merge pull request #7 from jillianKhoo/service-register 

    implementation of register user
    @jillianKhoo
    jillianKhoo authored Feb 3, 2019
    Configuration menu
    Copy the full SHA
    ddf6f3a View commit details
    Browse the repository at this point in the history

Commits on Feb 4, 2019

  1. tests and functionality for chirp and follow

    vagrant committed Feb 4, 2019
    Configuration menu
    Copy the full SHA
    16a7aaf View commit details
    Browse the repository at this point in the history

  2. header guard change

    vagrant committed Feb 4, 2019
    Configuration menu
    Copy the full SHA
    8112c34 View commit details
    Browse the repository at this point in the history

  3. PR fixes

    vagrant committed Feb 4, 2019
    Configuration menu
    Copy the full SHA
    e7035e7 View commit details
    Browse the repository at this point in the history

  4. PR fix

    vagrant committed Feb 4, 2019
    Configuration menu
    Copy the full SHA
    3566600 View commit details
    Browse the repository at this point in the history

  5. caught one more

    vagrant committed Feb 4, 2019
    Configuration menu
    Copy the full SHA
    98e46b4 View commit details
    Browse the repository at this point in the history

  6. Merge pull request #8 from jillianKhoo/service-layer-chirp-read 

    Service layer: Chirp and Read
    @jillianKhoo
    jillianKhoo authored Feb 4, 2019
    Configuration menu
    Copy the full SHA
    8f7c488 View commit details
    Browse the repository at this point in the history

Commits on Feb 5, 2019

  1. nothing works anymore

    vagrant committed Feb 5, 2019
    Configuration menu
    Copy the full SHA
    67baaef View commit details
    Browse the repository at this point in the history

  2. everything works again, fixed headers too

    vagrant committed Feb 5, 2019
    1 Configuration menu
    Copy the full SHA
    ccd4e48 View commit details
    Browse the repository at this point in the history

  3. scripts for compiling until I get a real makefile and header fixes

    vagrant committed Feb 5, 2019
    Configuration menu
    Copy the full SHA
    43b68ac View commit details
    Browse the repository at this point in the history

  4. realized I was including a generated file

    vagrant committed Feb 5, 2019
    Configuration menu
    Copy the full SHA
    7a2d9c1 View commit details
    Browse the repository at this point in the history

  5. updated gitignore

    vagrant committed Feb 5, 2019
    Configuration menu
    Copy the full SHA
    2e7d31c View commit details
    Browse the repository at this point in the history

Commits on Feb 6, 2019

  1. pr fix

    vagrant committed Feb 6, 2019
    Configuration menu
    Copy the full SHA
    9fb2526 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #9 from jillianKhoo/service-monitor 

    Monitor
    @jillianKhoo
    jillianKhoo authored Feb 6, 2019
    Configuration menu
    Copy the full SHA
    9889cc1 View commit details
    Browse the repository at this point in the history

  3. contact working from client to service layer, all tests still pass

    vagrant committed Feb 6, 2019
    Configuration menu
    Copy the full SHA
    d492a16 View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2019

  1. everything works

    vagrant committed Feb 7, 2019
    Configuration menu
    Copy the full SHA
    471aa62 View commit details
    Browse the repository at this point in the history

Commits on Feb 10, 2019

  1. everything works sort of

    vagrant committed Feb 10, 2019
    Configuration menu
    Copy the full SHA
    f915d24 View commit details
    Browse the repository at this point in the history

  2. everything works

    vagrant committed Feb 10, 2019
    Configuration menu
    Copy the full SHA
    5478a6c View commit details
    Browse the repository at this point in the history

  3. added fixes for edge cases and tests

    vagrant committed Feb 10, 2019
    Configuration menu
    Copy the full SHA
    c1d1585 View commit details
    Browse the repository at this point in the history

  4. code complete

    vagrant committed Feb 10, 2019
    Configuration menu
    Copy the full SHA
    8b9e92f View commit details
    Browse the repository at this point in the history

Commits on Feb 11, 2019

  1. added to README

    vagrant committed Feb 11, 2019
    Configuration menu
    Copy the full SHA
    af88185 View commit details
    Browse the repository at this point in the history

  2. finished cleanup

    vagrant committed Feb 11, 2019
    Configuration menu
    Copy the full SHA
    f2d294a View commit details
    Browse the repository at this point in the history

  3. PR fixes

    vagrant committed Feb 11, 2019
    Configuration menu
    Copy the full SHA
    47cfe01 View commit details
    Browse the repository at this point in the history

  4. PR fixed mutex

    vagrant committed Feb 11, 2019
    Configuration menu
    Copy the full SHA
    193343f View commit details
    Browse the repository at this point in the history

  5. Merge pull request #10 from jillianKhoo/client-to-server 

    Client to server connection and cleanup
    @jillianKhoo
    jillianKhoo authored Feb 11, 2019
    Configuration menu
    Copy the full SHA
    ef3bfd5 View commit details
    Browse the repository at this point in the history

Commits on Feb 12, 2019

  1. fixed readme, changed read to sort by timestamp, changed curr_id_ to … 

    …live in kv store
    vagrant committed Feb 12, 2019
    Configuration menu
    Copy the full SHA
    feaa0b1 View commit details
    Browse the repository at this point in the history

  2. I forgot what I fixed

    vagrant committed Feb 12, 2019
    Configuration menu
    Copy the full SHA
    64c048d View commit details
    Browse the repository at this point in the history

  3. Merge pull request #11 from jillianKhoo/small-details 

    Small details, mainly edge cases
    @jillianKhoo
    jillianKhoo authored Feb 12, 2019
    Configuration menu
    Copy the full SHA
    dad6567 View commit details
    Browse the repository at this point in the history

  4. spacing fix

    vagrant committed Feb 12, 2019
    Configuration menu
    Copy the full SHA
    74798fa View commit details
    Browse the repository at this point in the history

Commits on Feb 14, 2019

  1. bug where if you follow someone twice they get double chirps

    vagrant committed Feb 14, 2019
    Configuration menu
    Copy the full SHA
    40fc0c1 View commit details
    Browse the repository at this point in the history