fix: fix loaded entity num is inaccurate (milvus-io#33521)

issue: milvus-io#33520 Signed-off-by: jaime <[email protected]>
jiangyinzuo · Jun 4, 2024 · 8858fcb · 8858fcb
1 parent d610fdf
commit 8858fcb
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/internal/querynodev2/metrics_info.go b/internal/querynodev2/metrics_info.go
@@ -103,11 +103,12 @@ func getQuotaMetrics(node *QueryNode) (*metricsinfo.QueryNodeQuotaMetrics, error
 	}
 
 	minTsafeChannel, minTsafe := node.tSafeManager.Min()
-
 	collections := node.manager.Collection.List()
-
 	nodeID := fmt.Sprint(node.GetNodeID())
 
+	metrics.QueryNodeNumEntities.Reset()
+	metrics.QueryNodeEntitiesSize.Reset()
+
 	var totalGrowingSize int64
 	growingSegments := node.manager.Segment.GetBy(segments.WithType(segments.SegmentTypeGrowing))
 	growingGroupByCollection := lo.GroupBy(growingSegments, func(seg segments.Segment) int64 {
@@ -125,6 +126,7 @@ func getQuotaMetrics(node *QueryNode) (*metricsinfo.QueryNodeQuotaMetrics, error
 	growingGroupByPartition := lo.GroupBy(growingSegments, func(seg segments.Segment) int64 {
 		return seg.Partition()
 	})
+
 	for _, segs := range growingGroupByPartition {
 		numEntities := lo.SumBy(segs, func(seg segments.Segment) int64 {
 			return seg.RowNum()
@@ -136,7 +138,6 @@ func getQuotaMetrics(node *QueryNode) (*metricsinfo.QueryNodeQuotaMetrics, error
 			fmt.Sprint(segment.Collection()),
 			fmt.Sprint(segment.Partition()),
 			segments.SegmentTypeGrowing.String(),
-			fmt.Sprint(len(segment.Indexes())),
 		).Set(float64(numEntities))
 	}
 
@@ -166,7 +167,6 @@ func getQuotaMetrics(node *QueryNode) (*metricsinfo.QueryNodeQuotaMetrics, error
 			fmt.Sprint(segment.Collection()),
 			fmt.Sprint(segment.Partition()),
 			segments.SegmentTypeSealed.String(),
-			fmt.Sprint(len(segment.Indexes())),
 		).Set(float64(numEntities))
 	}
 

diff --git a/pkg/metrics/querynode_metrics.go b/pkg/metrics/querynode_metrics.go
@@ -370,7 +370,6 @@ var (
 			collectionIDLabelName,
 			partitionIDLabelName,
 			segmentStateLabelName,
-			indexCountLabelName,
 		})
 
 	QueryNodeEntitiesSize = prometheus.NewGaugeVec(