Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sandbox #10

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Sandbox #10

wants to merge 5 commits into from

Conversation

LukasRier
Copy link

Added option handling to allow for uploads to sandbox.zenodo.org ( Issue #9 )
The upload command can be run as before or including -s which adds "sandbox." to the URLs.

Invalid options will throw an error and exit.

add option [-sb] to indicate user is uploading to a zenodo repository in sandbox mode. Positional arguments are not optional and therefore indicated using < >
Initialise sandbox string, check for invalid options and reset option index for positional arguments later.
Inlcudes sandbox string (SBSTR) in relevant urls. sandbox.zenodo... if -s is set or leaves the urls unchanged if -s is not set
@LukasRier LukasRier marked this pull request as ready for review December 12, 2022 12:57
@jhpoelen
Copy link
Owner

jhpoelen commented Dec 7, 2023

Hi @LukasRier - apologies for the delay in responding to your pull request.

Are you still interested in adding sandbox options to the zenodo_upload script?

@LukasRier
Copy link
Author

Hi @jhpoelen - Yes I think it could be useful for testing uploads. Happy to take suggestions on how to implement this better though!

@jhpoelen
Copy link
Owner

@LukasRier I agree that having a sandbox option would be a nice addition.

Assuming you've tested the functionality, I'd be happy to merge your pull request.

I did notice that your suggested changes now conflict with the current versions. Can you please update your pull request after resolving the conflicts.

Thanks for taking the time to prepare the pull request, and let me know if you have any questions / comments on how to move forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants