Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow deleting headers #300

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Allow deleting headers #300

wants to merge 1 commit into from

Conversation

JHK
Copy link

@JHK JHK commented Nov 14, 2021

This makes it possible to unset a header.

@JHK
Copy link
Author

JHK commented Nov 22, 2021

Obviously it is also possible to add a method clear_header(header: string) or remove_header(header: string). I think explicitly setting a undefined value would meet peoples expectations already when they try to unset a header. Thus I went for this simple approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant