Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Tests to be a little more Resilient #41

Merged
merged 1 commit into from
Nov 15, 2023

Conversation

ChaelCodes
Copy link
Collaborator

  • Everyone gets generous epsilons, because tests based on time can be a bit flakey
  • test_nested_collections is now influenced by TEST_SLEEP_SCALE

We should document TEST_SLEEP_SCALE somewhere.

@ChaelCodes
Copy link
Collaborator Author

For the record, I think epsilon is the right method. If we return 3 but it expected 200, then it'll throw an error - which we want, but it'll be generous with 200 vs 150 or 400 vs 260.

@ChaelCodes ChaelCodes changed the title Update Tests to be little more Resilient Update Tests to be a little more Resilient Nov 14, 2023
@jhawthorn jhawthorn merged commit f40badf into jhawthorn:main Nov 15, 2023
4 checks passed
@jhawthorn
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants